Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Enhancement -- Adding two new mash types #205
This is an enhancement I've been working on for a while, but I think I finally got it right. I've added two new mash types: batchSparge and flySparge. The are considered by most of the code as infusion steps (which they basically are), but they do behave a little differently -- batchSparge assumes you've emptied the mash tun for example, and adding a flySparge step does not allow you to continue.
This should also close the issue #63
The ground work is in place, but I seem to have broken something pretty seriously in the mash designer. Commiting this so I can double check against the master. Second pass at doing this. The old branch was too old.
I tried to merge the old branch, had over 3k changes and came to my senses. I am apparently better at cherry picking then I am at merging. Who knew? I found my original problem in maxAmt_l, which was doing too much based on the mash type. I've tweeked the signals a little to make mash designer more responsive. Now to figure out what fly sparging does and means.
I fixed the volume problem. As I somewhat expected, it was a side effect of disabling the signals. The fix was to add a method to figure volume lost to the grain. There are still some oddities, but it seems to do the right thing. Started playing with the fly sparge settings a little. It will get more into the brewing methods idea I have, but curently you can't add another step after you select "fly sparge". I am going to continue working the idea, but this is the start.
Probably should have waited until the first request was merged, but I had an idea. The mash wizard now has a few extra options -- no sparge, batch sparge and fly sparge. Depending on the option you select, brewtarget does different things. You can also select the number of batch sparges. I will set up a new options panel to set the defaults for this. But first I need to merge/sync this vm with upstream.
Yeah. The postgresql changes moved some bits around, and this change added
I thought I had synced my master branch to the development branch, but