New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs with brewday step numbering (and database version update) #97

Closed
wants to merge 1 commit into
base: stable/2.2.0
from

Conversation

Projects
None yet
2 participants
@f1oki
Copy link
Contributor

f1oki commented Sep 29, 2015

Taken from here:

Also, when adding or taking out steps the step numbers do not change correctly; for example I'll end up with two "step 4's" and no step 5.

It took me some time (had no idea there was a trigger), but I found the bug and fixed it.

Furthermore, found (and fixed) another bug when updating the database version number.

@rocketman768

This comment has been minimized.

Copy link
Member

rocketman768 commented Oct 3, 2015

Awesome, thank you.

@rocketman768

This comment has been minimized.

Copy link
Member

rocketman768 commented Oct 6, 2015

Can you cherry-pick and repush this against brewtarget/master?

@rocketman768

This comment has been minimized.

Copy link
Member

rocketman768 commented Oct 6, 2015

@Brewtarget/developers this is a heads-up that the database schema is about to change.

@f1oki

This comment has been minimized.

Copy link
Contributor

f1oki commented Oct 6, 2015

For sure! I'll try to do it Friday or during the weekend.

@rocketman768

This comment has been minimized.

Copy link
Member

rocketman768 commented Oct 13, 2015

Will merge this immediately on a rebase to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment