Permalink
Browse files

Remove double slash in form media

If `settings.STATIC_URL` ends in a slash, it may raise a `SuspiciousOperation` error when run through tools like django-compressor. Removing trailing slashes from STATIC_URL fixes this.
  • Loading branch information...
BrianHicks committed Apr 2, 2013
1 parent 106eb62 commit 1f020639348efafaee790e09769d198d9c165367
Showing with 3 additions and 3 deletions.
  1. +3 −3 pagedown/widgets.py
View
@@ -12,9 +12,9 @@ class Media:
css = {
'all': ('pagedown/demo/browser/demo.css',)
}
- js = ('%s/pagedown/Markdown.Converter.js' % settings.STATIC_URL,
- '%s/pagedown/Markdown.Sanitizer.js' % settings.STATIC_URL,
- '%s/pagedown/Markdown.Editor.js' % settings.STATIC_URL,)
+ js = ('%s/pagedown/Markdown.Converter.js' % settings.STATIC_URL.rstrip('/'),
+ '%s/pagedown/Markdown.Sanitizer.js' % settings.STATIC_URL.rstrip('/'),
+ '%s/pagedown/Markdown.Editor.js' % settings.STATIC_URL.rstrip('/'),)
def render(self, name, value, attrs=None):
if value is None:

2 comments on commit 1f02063

@timmyomahony

This comment has been minimized.

Show comment Hide comment
@timmyomahony

timmyomahony Apr 2, 2013

Well spotted. Maybe I should actually rewrite the strings to %spagedown/Markdown.Converter.js (minus the starting slash) as the django docs recommend that the STATIC_URL always end in a slash? Although this way would ensure it works in both situtations

Well spotted. Maybe I should actually rewrite the strings to %spagedown/Markdown.Converter.js (minus the starting slash) as the django docs recommend that the STATIC_URL always end in a slash? Although this way would ensure it works in both situtations

@BrianHicks

This comment has been minimized.

Show comment Hide comment
@BrianHicks

BrianHicks Apr 2, 2013

Owner

That's what I was thinking - I've worked on projects both ways. I think it's better to work with the complete range of input rather than hard-coding it in either direction. Principle of least astonishment and all that.

Owner

BrianHicks replied Apr 2, 2013

That's what I was thinking - I've worked on projects both ways. I think it's better to work with the complete range of input rather than hard-coding it in either direction. Principle of least astonishment and all that.

Please sign in to comment.