New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blueprint for direct dependencies. #1

Closed
rwjblue opened this Issue Apr 4, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@rwjblue

rwjblue commented Apr 4, 2016

These lines are adding packages to the consuming project, but should really just be added to this projects list of dependencies. Adding them to the consuming project happens to work (due to node module resolution traversing upwards), but it is generally not great to add packages to the project if the project itself doesn't need to consume them. In this case, these packages are only used from within ember-stagger-swagger's index.js so putting them in dependencies here is the right way to go...

@BrianSipple

This comment has been minimized.

Show comment
Hide comment
@BrianSipple

BrianSipple Apr 4, 2016

Owner

Thanks for clarifying this! I've been going between both approaches after encountering a similarly-themed question in ember-cli-eslint, but now it clicked -- the distinction between whether or not the project itself needs to consume them.

Owner

BrianSipple commented Apr 4, 2016

Thanks for clarifying this! I've been going between both approaches after encountering a similarly-themed question in ember-cli-eslint, but now it clicked -- the distinction between whether or not the project itself needs to consume them.

@BrianSipple

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment