Add support for high resolution displays (e.g. 4k) and using correct … #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricknelson
force-pushed
the
high-res
branch
from
a055b47
to
04867f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this, made the setup process super quick and simple! This is just a quick mod to support 4k displays and fix it to use the correct icon. That and a minor typo correction. 😄 I think the release
.zipwould need to be repackaged too.Also, minor correction on the 32px icon as well as the
README.md: The icons used were for FluentTerminal (or at least are now representing it), however the correct icon should be this: https://twitter.com/cinnamon_msft/status/1141040460716134401Anyway the
icon-v2.pngwon't show until after the PR is merged. This is because<img>with an absolute source is being used for sizing/alignment purposes (just using-v2.pngto cache bust).Before/After: