Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for integer fields exhibits odd behavior #397

Closed
apazzolini opened this issue Sep 24, 2013 · 3 comments

Comments

@apazzolini
Copy link

@apazzolini apazzolini commented Sep 24, 2013

When attempting to add a product option value, if I put in a non-numeric value for either display order or price adjustment, the save will go through with those values as blank.

I would expect to see an error telling me I should input a valid number.

@ghost ghost assigned phillipuniverse Nov 12, 2013
@phillipuniverse

This comment has been minimized.

Copy link
Contributor

@phillipuniverse phillipuniverse commented Nov 12, 2013

Looks like this is a bug in Chrome only. See http://stackoverflow.com/questions/5345095/chrome-auto-formats-input-number which doesn't appear to actually be fixed; a blank value is still submitted to the server (although the stack overflow link specifically deals with accessing the value via Javascript).

Going to change from input type="number" to type="text" on these input fields. This actually effects all number fields (including Money, Integer and Decimal).

phillipuniverse added a commit that referenced this issue Nov 12, 2013
…ill submit a blank string to the server if there is a non-numeric value
@bpolster bpolster reopened this Nov 11, 2014
@bpolster

This comment has been minimized.

Copy link
Member

@bpolster bpolster commented Nov 11, 2014

Reopen per comment on commit 6b7dd31

@bpolster bpolster modified the milestones: 3.0.14-GA, 3.0.6-GA Nov 19, 2014
@phillipuniverse

This comment has been minimized.

Copy link
Contributor

@phillipuniverse phillipuniverse commented Nov 20, 2014

Resolved via the comment on 6b7dd31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.