Closing file stream before moving file to destination #769
Conversation
From [Images not showing](http://forum.broadleafcommerce.org/viewtopic.php?f=15&t=2441). Using IOUtils to close streams before moving files. Fixes BroadleafCommerce/DemoSite#81
|
Related to #715 |
|
@sunil0791 thanks for the commit, this is mostly right. I am going to merge this in and make a few modifications to it against this ticket. After the modifications are complete, if you could verify that they work that would be much appreciated. I do not have a readily available Windows development environment. Thanks! |
Fixes #769 - Closing file stream before moving file to destination to properly deal with uploading images on Windows
…with file uploads in Windows. Also made additional fixes to dealing with output streams and properly cleaning up if there were exceptions
|
@sunil0791 my changers are done, I'm building a new 3.1.1-SNAPSHOT version right now. Please test this out and let me know if it's working on your end. Thanks! |
|
@phillipuniverse srry was busy with something. I will test it out this weekend and let you know if this is resolved. |
|
@sunil0791 no problem. Actually, I thought you had the original pull request commit but that was @xshyamx. Would appreciate if both of you could help test this out; the more eyes we can get to confirm this the better! |
|
I can confirm that 3.1.1-SNAPSHOT works. |
…eproxy NPE in getCategory on OrderItem (e.g. Non Discrete Items / Non Catalog Items)
From Images not showing. Using IOUtils to close streams before moving files. Fixes BroadleafCommerce/DemoSite#81