fix(binding): early return when input images are optimized (#28)

* fix(binding): early return when input images are optimized

* ci: fix builds

* Fix build

* target feature

* Remove inline

* Thin lto

* Use GCC

Author: Brooooooklyn

.cargo/config.toml

@@ -1,7 +1,11 @@
+[target.i686-pc-windows-msvc]
+rustflags = ["-C", "target-feature=+sse4.2"]
+[target.x86_64-unknown-linux-gnu]
+rustflags = ["-C", "target-feature=+sse4.2"]
 [target.x86_64-unknown-linux-musl]
 rustflags = ["-C", "target-feature=-crt-static"]
 [target.aarch64-unknown-linux-gnu]
-linker = "aarch64-linux-gnu-gcc"
+rustflags = ["-C", "target-feature=+crc"]
 [target.aarch64-unknown-linux-musl]
 linker = "aarch64-linux-musl-gcc"
 rustflags = ["-C", "target-feature=-crt-static"]

.github/workflows/CI.yml

@@ -36,23 +36,27 @@ jobs:
               choco install meson -y
               yarn workspace @napi-rs/image build --features with_simd
             target: x86_64-pc-windows-msvc
-          - host: windows-2022-xl
+          - host: ubuntu-latest
+            setup: |
+              sudo apt update
+              sudo apt install meson -y
+              cargo install cargo-xwin
             build: |
-              $Env:PATH="C:\Cargo\bin;$Env:PATH"
-              $Env:LIBAVIF_CROSS_WIN32=1
+              export XWIN_ARCH=x86
+              export CFLAGS="-msse4.2"
+              export CXXFLAGS="-msse4.2"
               yarn workspace @napi-rs/image build --features with_simd --target i686-pc-windows-msvc
-              node -e "console.log(process.arch)"
-              yarn test
             target: i686-pc-windows-msvc
           - host: ubuntu-latest
             target: x86_64-unknown-linux-gnu
-            architecture: x64
             docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian
-            build: |
-              set -e && \
-              apt install meson -y && \
-              yarn workspace @napi-rs/image build --features with_simd --target x86_64-unknown-linux-gnu && \
-              strip packages/*/*.node
+            build: >-
+              set -e &&
+              apt-get update &&
+              apt-get install meson -y &&
+              unset LDFLAGS &&
+              CXX_x86_64_unknown_linux_gnu=g++ CC_x86_64_unknown_linux_gnu=gcc yarn workspace @napi-rs/image build --features with_simd --target x86_64-unknown-linux-gnu &&
+              llvm-strip packages/*/*.node
           - host: ubuntu-latest
             target: x86_64-unknown-linux-musl
             docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
@@ -73,17 +77,17 @@ jobs:
               brew install meson
               yarn workspace @napi-rs/image build --features with_simd
               strip -x packages/*/*.node
-          - host: ubuntu-18.04
-            architecture: x64
+          - host: ubuntu-latest
             target: aarch64-unknown-linux-gnu
-            setup: |
-              sudo apt-get update
-              sudo apt-get install meson g++-aarch64-linux-gnu gcc-aarch64-linux-gnu -y
-            build: |
-              yarn workspace @napi-rs/image build --features with_simd
-              aarch64-linux-gnu-strip packages/*/*.node
+            docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian-aarch64
+            build: >-
+              set -e &&
+              export LDFLAGS="-L/usr/aarch64-unknown-linux-gnu/lib/gcc/aarch64-unknown-linux-gnu/4.8.5" &&
+              export CFLAGS="-fuse-ld=lld -mcrc -B/usr/aarch64-unknown-linux-gnu/lib/gcc/aarch64-unknown-linux-gnu/4.8.5 --sysroot=/usr/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/sysroot" &&
+              export CXXFLAGS="-fuse-ld=lld -mcrc -B/usr/aarch64-unknown-linux-gnu/lib/gcc/aarch64-unknown-linux-gnu/4.8.5 --sysroot=/usr/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/sysroot" &&
+              yarn workspace @napi-rs/image build --features with_simd --target aarch64-unknown-linux-gnu &&
+              llvm-strip packages/*/*.node
           - host: ubuntu-18.04
-            architecture: x64
             target: armv7-unknown-linux-gnueabihf
             setup: |
               sudo apt-get update
@@ -92,34 +96,22 @@ jobs:
               yarn workspace @napi-rs/image build --features oxipng_libdeflater
               arm-linux-gnueabihf-strip packages/*/*.node
           - host: ubuntu-latest
-            architecture: x64
             target: aarch64-linux-android
             build: |
               sudo apt update
               sudo apt install meson -y
-              export CARGO_TARGET_AARCH64_LINUX_ANDROID_LINKER="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang"
-              export CC="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang"
-              export CXX="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang++"
-              export AR="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar"
-              export PATH="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin:${PATH}"
               yarn workspace @napi-rs/image build --features with_simd
               ${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-strip packages/*/*.node
           - host: ubuntu-latest
-            architecture: x64
             target: armv7-linux-androideabi
             build: |
               sudo apt update
               sudo apt install meson -y
-              export CARGO_TARGET_ARMV7_LINUX_ANDROIDEABI_LINKER="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi24-clang"
-              export CC="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi24-clang"
-              export CXX="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi24-clang++"
-              export AR="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar"
-              export PATH="${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin:${PATH}"
-              export C_INCLUDE_PATH="${ANDROID_NDK_LATEST_HOME}/sources/android/cpufeatures"; 
+              export C_INCLUDE_PATH="${ANDROID_NDK_LATEST_HOME}/sources/android/cpufeatures";
+              export CMAKE_TOOLCHAIN_FILE_armv7_linux_androideabi="${ANDROID_NDK_LATEST_HOME}/build/cmake/android.toolchain.cmake";
               yarn workspace @napi-rs/image build --features oxipng_libdeflater
               ${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-strip packages/*/*.node
           - host: ubuntu-latest
-            architecture: x64
             target: aarch64-unknown-linux-musl
             downloadTarget: aarch64-unknown-linux-musl
             docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
@@ -148,7 +140,6 @@ jobs:
         if: matrix.settings.target == 'x86_64-pc-windows-msvc' || matrix.settings.target == 'x86_64-apple-darwin' || matrix.settings.target == 'i686-pc-windows-msvc'
       - name: Install
         uses: actions-rs/toolchain@v1
-        if: matrix.settings.target != 'i686-pc-windows-msvc'
         with:
           profile: minimal
           override: true
@@ -163,29 +154,22 @@ jobs:
             ~/.cargo/git/db/
             .cargo-cache
             target/
-          key: ${{ matrix.settings.target }}-cargo-registry
-      - name: Cache NPM dependencies
-        uses: actions/cache@v3
+          key: ${{ matrix.settings.target }}-cargo-cache
+      - uses: goto-bus-stop/setup-zig@v2
+        if: ${{ matrix.settings.target == 'aarch64-unknown-linux-gnu' }}
         with:
-          path: .yarn/cache
-          key: npm-cache-${{ matrix.settings.target }}-node@16
+          version: 0.10.0
+      - name: Install LLVM and Clang
+        uses: KyleMayes/install-llvm-action@v1
+        if: ${{ matrix.settings.target == 'i686-pc-windows-msvc' }}
+        with:
+          version: '15'
       - name: Setup toolchain
         run: ${{ matrix.settings.setup }}
         if: ${{ matrix.settings.setup }}
         shell: bash
-      - name: Setup node x86 install settings
-        if: matrix.settings.target == 'i686-pc-windows-msvc'
-        run: yarn config set supportedArchitectures.cpu --json '["x86", "x64"]'
-        shell: bash
       - name: Install dependencies
         run: yarn install --immutable --mode=skip-build
-      - name: Setup node x86
-        uses: actions/setup-node@v3
-        if: matrix.settings.target == 'i686-pc-windows-msvc'
-        with:
-          node-version: 16
-          check-latest: true
-          architecture: x86
       - name: Build in docker
         uses: addnab/docker-run-action@v3
         if: ${{ matrix.settings.docker }}
@@ -195,14 +179,10 @@ jobs:
           run: ${{ matrix.settings.build }}
       - name: Build
         run: ${{ matrix.settings.build }}
-        if: ${{ !matrix.settings.docker && matrix.settings.target != 'i686-pc-windows-msvc' }}
+        if: ${{ !matrix.settings.docker }}
         shell: bash
-      - name: Build
-        run: ${{ matrix.settings.build }}
-        if: matrix.settings.target == 'i686-pc-windows-msvc'
-        shell: powershell
       - name: Upload artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with:
           name: bindings-${{ matrix.settings.target }}
           path: packages/*/*.node
@@ -214,7 +194,7 @@ jobs:
       - uses: actions/checkout@v3
       - name: Build
         id: build
-        uses: vmactions/freebsd-vm@v0.2.3
+        uses: vmactions/freebsd-vm@v0
         env:
           DEBUG: napi:*
           RUSTUP_HOME: /usr/local/rustup
@@ -225,7 +205,7 @@ jobs:
           usesh: true
           mem: 3000
           prepare: |
-            pkg install -y curl cmake nasm node16 python2 perl5
+            pkg install -y curl cmake nasm node perl5
             curl -qL https://www.npmjs.com/install.sh | sh
             npm install --location=global --ignore-scripts yarn
             curl https://sh.rustup.rs -sSf --output rustup.sh
@@ -252,7 +232,7 @@ jobs:
             rm -rf node_modules
             rm -rf target
       - name: Upload artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with:
           name: bindings-freebsd
           path: packages/*/*.node
@@ -482,11 +462,6 @@ jobs:
           node-version: 16
           check-latest: true
           cache: yarn
-      - name: Cache NPM dependencies
-        uses: actions/cache@v3
-        with:
-          path: .yarn/cache
-          key: npm-cache-ubuntu-latest-publish
       - name: Install dependencies
         run: yarn install --immutable --mode=skip-build
       - name: Download all artifacts