Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async module #416

Merged
merged 2 commits into from Feb 1, 2015

Conversation

Projects
None yet
2 participants
@shinnn
Copy link
Contributor

commented Feb 1, 2015

It’s not needed any longer.

BrowserSync/UI#3

shinnn added some commits Feb 1, 2015

Remove async module
It’s not needed any longer.

BrowserSync/UI#3
@shinnn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2015

Passed the test on both CI services.

@shakyShane

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2015

⭐️

shakyShane added a commit that referenced this pull request Feb 1, 2015

@shakyShane shakyShane merged commit dfd09c9 into BrowserSync:master Feb 1, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@shinnn shinnn deleted the shinnn:remove-async branch Feb 1, 2015

@shinnn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2015

This gist helps you create cross-platform Node program.
https://gist.github.com/domenic/2790533

Especially, you shouldn't concatenate __dirname and the other path string. We should always use path.* methods instead.

@shinnn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2015

By the way, I'm opposed to export external libs here.

https://github.com/shakyShane/browser-sync/blob/d203c04d08a82ce1c700c969caad520621d12fac/lib/utils.js#L346-L352

We are using Node, that is to say, we are using Common-JS. If the lib is needed, we should require the lib instead.

@shakyShane

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2015

My goal was the removal of extra dependencies from the UI. Although it is technically a plugin to BrowserSync, it is inextricably linked. The idea of maintaining two sets of dependencies seemed more overhead that it's worth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.