From 6cd4c171b82c567264a8c9d35fe0ed0f975ce450 Mon Sep 17 00:00:00 2001 From: Jan de Mooij Date: Thu, 1 Jan 1970 00:00:00 +0000 Subject: [PATCH] Bug 1607443 - Fix some alias sets. r=tcampbell, a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D58956 --HG-- extra : source : d6e40de88f3defdc12ef27e64ca73e120b1f10e2 extra : intermediate-source : 8260da04c9b13f7c0e9cc6984a75e689b5fcb8c8 --- js/src/jit/AliasAnalysis.cpp | 4 ++-- js/src/jit/MIR.h | 9 --------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/js/src/jit/AliasAnalysis.cpp b/js/src/jit/AliasAnalysis.cpp index c4cba138828ec..23444428884cd 100644 --- a/js/src/jit/AliasAnalysis.cpp +++ b/js/src/jit/AliasAnalysis.cpp @@ -120,8 +120,6 @@ static inline const MDefinition* GetObject(const MDefinition* ins) { case MDefinition::Opcode::SetInitializedLength: case MDefinition::Opcode::ArrayLength: case MDefinition::Opcode::SetArrayLength: - case MDefinition::Opcode::StoreElementHole: - case MDefinition::Opcode::FallibleStoreElement: case MDefinition::Opcode::TypedObjectDescr: case MDefinition::Opcode::Slots: case MDefinition::Opcode::Elements: @@ -182,6 +180,8 @@ static inline const MDefinition* GetObject(const MDefinition* ins) { case MDefinition::Opcode::WasmStoreRef: case MDefinition::Opcode::ArrayJoin: case MDefinition::Opcode::ArraySlice: + case MDefinition::Opcode::StoreElementHole: + case MDefinition::Opcode::FallibleStoreElement: return nullptr; default: #ifdef DEBUG diff --git a/js/src/jit/MIR.h b/js/src/jit/MIR.h index 908ce17fa6417..6bc5893ef1394 100644 --- a/js/src/jit/MIR.h +++ b/js/src/jit/MIR.h @@ -7792,12 +7792,6 @@ class MStoreElementHole TRIVIAL_NEW_WRAPPERS NAMED_OPERANDS((0, object), (1, elements), (2, index), (3, value)) - AliasSet getAliasSet() const override { - // StoreElementHole can update the initialized length, the array length - // or reallocate obj->elements. - return AliasSet::Store(AliasSet::ObjectFields | AliasSet::Element); - } - ALLOW_CLONE(MStoreElementHole) }; @@ -7824,9 +7818,6 @@ class MFallibleStoreElement TRIVIAL_NEW_WRAPPERS NAMED_OPERANDS((0, object), (1, elements), (2, index), (3, value)) - AliasSet getAliasSet() const override { - return AliasSet::Store(AliasSet::ObjectFields | AliasSet::Element); - } bool needsHoleCheck() const { return needsHoleCheck_; } ALLOW_CLONE(MFallibleStoreElement)