From 3099f36e5e65ba734ac5a4af212165d05dd09b27 Mon Sep 17 00:00:00 2001 From: Dave Plunkett Date: Mon, 16 Dec 2024 10:36:43 -0700 Subject: [PATCH 1/2] Added dumpfileSize member --- src/crash/crash-details/crash-details.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/crash/crash-details/crash-details.ts b/src/crash/crash-details/crash-details.ts index db8b340..1c25ed7 100644 --- a/src/crash/crash-details/crash-details.ts +++ b/src/crash/crash-details/crash-details.ts @@ -45,6 +45,7 @@ export interface CrashDetails { defectUrl: string; description: string; dumpfile: string; + dumpfileSize: number; email: string; events: Array; exceptionCode: string; @@ -153,4 +154,4 @@ function defaultToEmptyString(value, name) { } else { return ''; } -} \ No newline at end of file +} From 8f86e8deec172d85560e8702e930e7ed0ff97d6e Mon Sep 17 00:00:00 2001 From: Dave Date: Mon, 16 Dec 2024 11:41:38 -0700 Subject: [PATCH 2/2] feat: add dumpfileSize --- package-lock.json | 1 - spec/fakes/crash/crash-api-response.ts | 1 + src/crash/crash-details/crash-details.spec.ts | 1 + src/crash/crash-details/crash-details.ts | 1 + 4 files changed, 3 insertions(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index f936361..d644aaa 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9010,7 +9010,6 @@ "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.7.2.tgz", "integrity": "sha512-i5t66RHxDvVN40HfDd1PsEThGNnlMCMT3jMUuoh9/0TaqWevNontacunWyN02LA9/fIbEWlcHZcgTKb9QoaLfg==", "dev": true, - "license": "Apache-2.0", "bin": { "tsc": "bin/tsc", "tsserver": "bin/tsserver" diff --git a/spec/fakes/crash/crash-api-response.ts b/spec/fakes/crash/crash-api-response.ts index 98f393f..d3a85f2 100644 --- a/spec/fakes/crash/crash-api-response.ts +++ b/spec/fakes/crash/crash-api-response.ts @@ -16,6 +16,7 @@ export const createFakeCrashApiResponse = () => ({ defectUrl: 'http://newayz.net', description: 'haa!', dumpfile: '💩', + dumpfileSize: 42, email: 'bobby@newayz.net', events: createFakeEvents([EventType.Comment]), exceptionCode: '0010', diff --git a/src/crash/crash-details/crash-details.spec.ts b/src/crash/crash-details/crash-details.spec.ts index a855a8f..f3281a8 100644 --- a/src/crash/crash-details/crash-details.spec.ts +++ b/src/crash/crash-details/crash-details.spec.ts @@ -29,6 +29,7 @@ describe('createCrashDetails', () => { stackId: 11372, stackKeyId: 1364, dumpfile: '/fred/myconsolecrasher-2019.2.3.0/2019/02/03/myconsolecrasher_2019.2.3.0_orgjilct-1706618358.zip', + dumpfileSize: 42, appName: 'myConsoleCrasher', appVersion: '2019.2.3.0', appKey: '', diff --git a/src/crash/crash-details/crash-details.ts b/src/crash/crash-details/crash-details.ts index 1c25ed7..98f9e78 100644 --- a/src/crash/crash-details/crash-details.ts +++ b/src/crash/crash-details/crash-details.ts @@ -75,6 +75,7 @@ export function createCrashDetails(options: CrashDetailsRawResponse): CrashDetai ac.assertNumber(options.id, 'options.id'); ac.assertNumber(options.stackKeyId, 'options.stackKeyId'); ac.assertBoolean(options.missingSymbols, 'options.missingSymbols'); + ac.assertNumber(options.dumpfileSize, 'options.dumpfileSize'); const appName = defaultToEmptyString(options.appName, 'options.appName'); const appVersion = defaultToEmptyString(options.appVersion, 'options.appVersion');