From 2ac4819d9fe8be82eb468d205e33b613e7d47c90 Mon Sep 17 00:00:00 2001
From: Bobby Galli <bobbyg603@gmail.com>
Date: Sun, 22 Aug 2021 17:32:05 -0400
Subject: [PATCH 1/2] Should not throw when creating initials on event with
 undefined username Fixes #32

---
 src/events/event/create-event-from-api-response.ts |  2 +-
 src/events/event/event.spec.ts                     | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/events/event/create-event-from-api-response.ts b/src/events/event/create-event-from-api-response.ts
index 0a9de8c..e7afbff 100644
--- a/src/events/event/create-event-from-api-response.ts
+++ b/src/events/event/create-event-from-api-response.ts
@@ -21,5 +21,5 @@ function getInitialsOrDefault(event: any): string {
         return `${firstInitial}${lastInitial}`;
     }
 
-    return event.username.substring(0, 2);
+    return event.username?.substring(0, 2) ?? '';
 }
\ No newline at end of file
diff --git a/src/events/event/event.spec.ts b/src/events/event/event.spec.ts
index 1e093f4..5202161 100644
--- a/src/events/event/event.spec.ts
+++ b/src/events/event/event.spec.ts
@@ -53,5 +53,16 @@ describe('Events', () => {
                 jasmine.arrayContaining([expected])
             );
         });
+
+        it('should return empty string if username is null or undefined', () => {
+            const eventWithoutUsername = {
+                ...fakeEvents[0],
+                username: undefined
+            };
+
+            const results = convertEventsToEventStreamEvents([eventWithoutUsername]);
+
+            expect(results[0].subject.initials).toEqual('');
+        });
     });
 });
\ No newline at end of file

From 75ea9c8cb800e5979596ecd07b120d1c83eecfe6 Mon Sep 17 00:00:00 2001
From: Bobby Galli <bobbyg603@gmail.com>
Date: Wed, 25 Aug 2021 11:21:07 -0400
Subject: [PATCH 2/2] Fixes broken test

---
 src/crash/crash-api-client/crash-api-client.e2e.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/crash/crash-api-client/crash-api-client.e2e.ts b/src/crash/crash-api-client/crash-api-client.e2e.ts
index a27179a..6b8c1f3 100644
--- a/src/crash/crash-api-client/crash-api-client.e2e.ts
+++ b/src/crash/crash-api-client/crash-api-client.e2e.ts
@@ -28,7 +28,7 @@ describe('CrashApiClient', () => {
     describe('reprocessCrash', () => {
         it('should return 200 for database fred and a recent crash that has symbols', async () => {
             // TODO BG https://github.com/BugSplat-Git/bugsplat-js-api-client/issues/19
-            const response = await client.reprocessCrash(database, 100820);
+            const response = await client.reprocessCrash(database, 103339);
 
             expect(response.success).toEqual(true);
         });