From ed4cfe9c65af75ad582e46bf1d6c7d0cb9fff87f Mon Sep 17 00:00:00 2001 From: Phillip Bosek Date: Mon, 14 Apr 2025 16:46:36 -0400 Subject: [PATCH 1/2] fix: only dump symbols if on Android --- Editor/PostBuild.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Editor/PostBuild.cs b/Editor/PostBuild.cs index 7bb4851..aa99771 100644 --- a/Editor/PostBuild.cs +++ b/Editor/PostBuild.cs @@ -284,7 +284,11 @@ private static void UploadSymbols(string artifactsDirPath, string globPattern, B UseShellExecute = false, RedirectStandardOutput = true, Arguments = $"--database {options.Database} --application \"{application}\" --clientId {options.SymbolUploadClientId} --clientSecret {options.SymbolUploadClientSecret} " + - $"--version \"{version}\" --files \"{globPattern}\" --directory \"{artifactsDirPath}\" --dumpSyms" + $"--version \"{version}\" --files \"{globPattern}\" --directory \"{artifactsDirPath}\"" + }; + + if (Application.platform == RuntimePlatform.Android) { + symUploadProcessInfo.Arguments += "--dumpSyms"; }; var uploadSymProcess = Process.Start(symUploadProcessInfo); From df0352faf13bd75f49a626ab9f20d75f6a4bb7bf Mon Sep 17 00:00:00 2001 From: Phillip Bosek Date: Mon, 14 Apr 2025 18:08:49 -0400 Subject: [PATCH 2/2] fix: unity 6 support for android symbols --- Editor/PostBuild.cs | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/Editor/PostBuild.cs b/Editor/PostBuild.cs index aa99771..3a797a6 100644 --- a/Editor/PostBuild.cs +++ b/Editor/PostBuild.cs @@ -9,10 +9,13 @@ using UnityEditor; using UnityEditor.Callbacks; using UnityEngine; +using Unity.Android.Types; using BugSplatUnity.Runtime.Client; using Debug = UnityEngine.Debug; using BugSplatDotNetStandard.Api; using BugSplatDotNetStandard.Http; +using Unity.Android.Gradle; +using UserBuildSettings = UnityEditor.Android.UserBuildSettings; #if UNITY_IOS using UnityEditor.iOS.Xcode; @@ -70,7 +73,7 @@ public static void OnPostprocessBuild(BuildTarget target, string pathToBuiltProj #if UNITY_EDITOR_WIN private static void UploadSymbolFilesWin(string pathToBuiltProject, BugSplatOptions options) { - if (!UserBuildSettings.copyPDBFiles) + if (!UnityEditor.WindowsStandalone.UserBuildSettings.copyPDBFiles) { Debug.LogWarning("BugSplat. Skipping symbols uploading since \"Copy PDB files\" is disabled in BuildSettings->Windows."); return; @@ -194,9 +197,9 @@ private static void UploadSymbolsAndroid(string pathToBuiltProject, BugSplatOpti return; } - if (EditorUserBuildSettings.androidCreateSymbols == AndroidCreateSymbols.Disabled) + if (UserBuildSettings.DebugSymbols.level == DebugSymbolLevel.None) { - Debug.LogWarning("BugSplat. Skipping symbols uploading since \"Create symbols.zip\" is not configured in BuildSettings->Android."); + Debug.LogWarning("BugSplat. Skipping symbols uploading since \"Debug Symbols\" is set to None in BuildSettings->Android."); return; } @@ -287,10 +290,10 @@ private static void UploadSymbols(string artifactsDirPath, string globPattern, B $"--version \"{version}\" --files \"{globPattern}\" --directory \"{artifactsDirPath}\"" }; - if (Application.platform == RuntimePlatform.Android) { - symUploadProcessInfo.Arguments += "--dumpSyms"; + if (EditorUserBuildSettings.activeBuildTarget == BuildTarget.Android) { + symUploadProcessInfo.Arguments += " --dumpSyms"; }; - + var uploadSymProcess = Process.Start(symUploadProcessInfo); if (uploadSymProcess == null) {