New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robots only charge to 20% when "go to home" is true #3000

Closed
chemdork123 opened this Issue Sep 3, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@chemdork123

chemdork123 commented Sep 3, 2015

Robot recharging appears to not work properly in BC 7.0.20 when the robots power level is below 20% unless they are working in an area. The robot will charge only to 20%, then head back home... then shortly go below 20% and go back to the charging station and be locked into this back and forth forever.

This appears to only happen with robots who are set to "go to home", on their way "home", or sitting in "home". For example, a robot less than 20% when placed onto a docking station that is being given a command "go to home" will seek a power station, fill to 20% and exhibit the same behavior issue. Robots "working in area" appear to have no problem filling to 100% charge before returning to work.

Is this a bug?

@asiekierka

This comment has been minimized.

Member

asiekierka commented Sep 4, 2015

Yes, this is quite a bug.

@asiekierka

This comment has been minimized.

Member

asiekierka commented Sep 4, 2015

(Also, could not reproduce. At least not on 7.0.21)

@chemdork123

This comment has been minimized.

chemdork123 commented Sep 4, 2015

Hm. I'll try it again on 7.0.21... Happened when the robot was being given the "go to home" action, both with and without a map location marker.

@hea3ven

This comment has been minimized.

Contributor

hea3ven commented Sep 4, 2015

From only reading the code, it should happen in 7.0.x, it was introduced here 9ee5947#diff-4c137d7b470a3782fcdcfb2d8f174d5dL29 . If you re-add the "!(ai instanceof AIRobotRecharge)" condition back to prevent the overriding ai from starting, it should fix it.

@chemdork123

This comment has been minimized.

chemdork123 commented Sep 4, 2015

Yeah, it still happens for me in 7.0.21, but seems that this is expected from the code. Thanks, @hea3ven.

@asiekierka

This comment has been minimized.

Member

asiekierka commented Sep 4, 2015

Thanks, @hea3ven! Fixing it now...

@asiekierka asiekierka added the type: bug label Sep 4, 2015

@asiekierka asiekierka added this to the BuildCraft 7.0.22 milestone Sep 4, 2015

@asiekierka asiekierka closed this in e3ff1ea Sep 4, 2015

@asiekierka

This comment has been minimized.

Member

asiekierka commented Sep 4, 2015

By the way, nice 3000 GET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment