Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oil spawn in mid-air on superflat #3837

Closed
n00b7 opened this issue Oct 29, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@n00b7
Copy link

commented Oct 29, 2017

Buildcraft version: 7.99.7
Forge version: 1.11.2-13.20.1.2516

Additional information:
2017-10-29_08 11 57

@AlexIIL AlexIIL self-assigned this Oct 29, 2017

asiekierka added a commit that referenced this issue Nov 10, 2017

@AEnterprise

This comment has been minimized.

Copy link
Member

commented Nov 24, 2017

did this get applied to the 8.0.x branch as well?

@border999

This comment has been minimized.

Copy link

commented Nov 27, 2017

I can add to this in saying this issue is still in the 1.12.2 release. Found one exactly like this in the twilight forest.

@AEnterprise

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

the twilight forest isn't a superflat so a bit of a seperate issue, you can prevent oil spawning in there by adding the dimension to the blacklist in the config

@border999

This comment has been minimized.

Copy link

commented Nov 27, 2017

I was just noting it because the twilight forest has a ground level at around 32 blocks up. It seems somewhat relevant that this issue is seemingly universal to any dimension that doesn't have a ground level at block 64.

@AEnterprise

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

that's a seperate thing and is to avoid runaway terraingen, the determining of a ground lvl needs to be re-added but that's not easy while still trying to avoid runaway terraingen

@AlexIIL

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

I suppose there are technically 2 different issues here: that oil spawns in superflat biomes (at all), and that the oil tendrils are hardcoded to generate at y=64, even in the overworld. The first one can probably be fixed by cancelling generation if the world type is superflat, the second might be fixable by moving where Y-level of the tendril is decided from the generation code to the normal generation code.

scagood added a commit to scagood/BuildCraft that referenced this issue Sep 24, 2018

@AlexIIL AlexIIL removed their assignment Sep 24, 2018

@AlexIIL

This comment has been minimized.

Copy link
Member

commented Sep 30, 2018

Fixed by @scagood in #4271, and will be a part of 7.99.19 at some point in the future.

@AEnterprise AEnterprise closed this Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.