Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla flowing water blocks are invisible with BC installed #4044

Open
Tyler799 opened this issue Feb 20, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@Tyler799
Copy link

commented Feb 20, 2018

BuildCraft version: 7.99.15 (compat. 7.99.14)
Forge version: 14.23.2.2618
Link to crash report or log: N/A
Singleplayer or multiplayer: Singleplayer
Steps to reproduce: Find flowing water?
Additional information:

It's like it says on the tin. I was as surprised to come to this result as anyone else.

I tried disabling every single one of my other mods. After a couple hours of enabling/disabling mods and testing, I've found only Buildcraft to be the mod I need to enable to cause the issue, and disable to fix the issue.

It's very odd.

Obviously, it could be conflicting with another mod somehow, but I disabled anything even possibly water-related (Smoothwater, OptiFine, FoamFix Anarchy, TexFix, Dynamic Surroundings, Fancy Block Particles, etc) and BC still caused the issue when enabled.

Here's my mod list if it helps. https://pastebin.com/raw/sRZStcKF

@AEnterprise

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

BC does not mess with water or rendering in any way so there must be another mod involved as well

try making an instance where you ONLY have BC installed and no other mods, it shoudn't heapen there. Then you can add/remove mods with a binary search (but leaving BC in all the time) to find the other mod that is involved

@Tyler799

This comment has been minimized.

Copy link
Author

commented Feb 24, 2018

Unsurprisingly, it is a conflict with Optifine C9. Optifine does have this tendency to break things.

If either Buildcraft or Optifine is enabled, water is fine. But with them both enabled, the rendering for flowing water breaks.

I tried quite a few setting changes in OF, but none seemed to restore flowing water. At least, the ones I could test. A good half of them ended up crashing the game. Bleh.

EDIT: Anisotrophic filtering needs to be on.

So, for clarity:

Buildcraft alone: No issue
Optifine alone: No issue
Optfine with Anisotrophic Filtering on: No issue
Buildcraft + Optfine: No issue
Buildcraft + Optfine with Anisotrophic Filtering: Flowing water is invisible

How does this even happen. Wat.

@AEnterprise

This comment has been minimized.

Copy link
Member

commented Feb 24, 2018

no clue, probably something about BC sprites is somehow making optifine shit itself yet again. you're gona want to report this to optifine to be fixed. Even if it is on their end he should be aware and probably has an idea of what might be causing this

@Tyler799

This comment has been minimized.

Copy link
Author

commented Feb 24, 2018

Already reported it to them.

@AlexIIL

This comment has been minimized.

Copy link
Member

commented Feb 24, 2018

(Link to optifine issue: sp614x/optifine#1243)

@AEnterprise

This comment has been minimized.

Copy link
Member

commented Mar 23, 2018

closing as optifine issue and nothing we can fix from our end, see issue above

@AlexIIL

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

I think this happens because we depend on the flowing water sprite for the pipe filter (in silicon), and so we replace that sprite (even though vanilla will load it later anyway).

It should be possible to fix this by not loading certain sprites as swappable.

@AlexIIL AlexIIL reopened this Nov 8, 2018

@AlexIIL AlexIIL added the type: bug label Nov 8, 2018

@AlexIIL AlexIIL self-assigned this Nov 8, 2018

@AlexIIL

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

(Obviously that fix won't help for any of the other BC swappable sprites but it's still better than nothing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.