Skip to content

Heat Exchanger gets blocked on certain fluid amounts #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LordGolias opened this issue Apr 21, 2018 · 3 comments
Closed

Heat Exchanger gets blocked on certain fluid amounts #4135

LordGolias opened this issue Apr 21, 2018 · 3 comments
Labels
status: fixed/implemented in dev We've fixed this internally, however the fix hasn't been released publicly yet. version: 1.12.2

Comments

@LordGolias
Copy link
Collaborator

LordGolias commented Apr 21, 2018 •
edited
Loading

BuildCraft version: 7.99.17
Singleplayer or multiplayer: both

Consider the path

oil (cold) -> Distiller -> Heavy Oil (375 mB) + Fuel Gas (2 B)

If the 375mB of Heavy Oil is sent to the Heat Exchanger (HE), the HE it will only consume 370 mB of the fluid. More importantly, the remaining 5mB will be stuck at the entrance of the HE, causing no other kind of liquid to enter until e.g. 365mB of the same liquid arrives to the HE.

IMO, the HE should probably not store liquids on its ends and instead only accept liquids from the input pipe to the output pipe (with cooling/heating). This facilitates using the HE on more complex and fun designs where it is being used to heat different types of liquids during operations.
@LuigiHutch
Copy link
Contributor

Duplicate of #3780

@LordGolias LordGolias mentioned this issue Apr 22, 2018
Open
@LordGolias LordGolias reopened this Apr 22, 2018
@LordGolias
Copy link
Collaborator Author

This is about the heat exchanger. The other is about the distiller.

@AEnterprise AEnterprise reopened this Apr 22, 2018
@AEnterprise AEnterprise added status: fixed/implemented in dev We've fixed this internally, however the fix hasn't been released publicly yet. version: 1.12.2 labels Apr 22, 2018
Tencao pushed a commit to Tencao/BuildCraft that referenced this issue Apr 27, 2018
@LordGolias @Tencao
Improvements to Heat Exchanger code (BuildCraft#4136)
d9a178e 
* Removed unused code.

* Fix BuildCraft#4135 - Made Heat Exchanger to receive multiples of 5

This changed processing speed of Heat Exchanger
allowing to process every combination of fluids from the distiller.

Also removed the multiplier non-divisible by 1000 that
was in contradiction to the comment.

* Made Heat Exchanger process with valid multiples

This fixes a todo on the code on which the multiple of the processing
given by the HE size was fixed, causing no smaller multiples to
be processed.

Tested ingame that 375 mB is now fully processed by the exchanger
in parts (37*10 + 5*1).

* Made Heat Exchanger process arbitrary amounts of fluid.

* Added entry to changelog.

(cherry picked from commit b952a7d)
@Dame-E-in
Copy link

This issue looks like a mess. Wow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: fixed/implemented in dev We've fixed this internally, however the fix hasn't been released publicly yet. version: 1.12.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AEnterprise @LuigiHutch @LordGolias @Dame-E-in