Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat Exchanger gets blocked on certain fluid amounts #4135

Closed
LordGolias opened this Issue Apr 21, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@LordGolias
Copy link
Collaborator

LordGolias commented Apr 21, 2018

BuildCraft version: 7.99.17
Singleplayer or multiplayer: both

Consider the path

oil (cold) -> Distiller -> Heavy Oil (375 mB) + Fuel Gas (2 B)

If the 375mB of Heavy Oil is sent to the Heat Exchanger (HE), the HE it will only consume 370 mB of the fluid. More importantly, the remaining 5mB will be stuck at the entrance of the HE, causing no other kind of liquid to enter until e.g. 365mB of the same liquid arrives to the HE.

IMO, the HE should probably not store liquids on its ends and instead only accept liquids from the input pipe to the output pipe (with cooling/heating). This facilitates using the HE on more complex and fun designs where it is being used to heat different types of liquids during operations.

@LuigiHutch

This comment has been minimized.

Copy link
Contributor

LuigiHutch commented Apr 21, 2018

Duplicate of #3780

@LordGolias

This comment has been minimized.

Copy link
Collaborator Author

LordGolias commented Apr 22, 2018

This is about the heat exchanger. The other is about the distiller.

LordGolias added a commit to LordGolias/BuildCraft that referenced this issue Apr 22, 2018

Fix BuildCraft#4135 - Made Heat Exchanger slower for the 1-middle-sec…
…tion aparatus.

This allows the Heat Exchanger to receive multiples of 5, which
allows to process every combination of fluids from the distiller.

Also removed the multiplier non-divisible by 1000 that
was in contradiction to the comment.

LordGolias added a commit to LordGolias/BuildCraft that referenced this issue Apr 22, 2018

Fix BuildCraft#4135 - Made Heat Exchanger to receive multiples of 5
This changed processing speed of Heat Exchanger
allowing to process every combination of fluids from the distiller.

Also removed the multiplier non-divisible by 1000 that
was in contradiction to the comment.

@AlexIIL AlexIIL closed this in b952a7d Apr 22, 2018

@AEnterprise AEnterprise reopened this Apr 22, 2018

Tencao added a commit to Tencao/BuildCraft that referenced this issue Apr 27, 2018

Improvements to Heat Exchanger code (BuildCraft#4136)
* Removed unused code.

* Fix BuildCraft#4135 - Made Heat Exchanger to receive multiples of 5

This changed processing speed of Heat Exchanger
allowing to process every combination of fluids from the distiller.

Also removed the multiplier non-divisible by 1000 that
was in contradiction to the comment.

* Made Heat Exchanger process with valid multiples

This fixes a todo on the code on which the multiple of the processing
given by the HE size was fixed, causing no smaller multiples to
be processed.

Tested ingame that 375 mB is now fully processed by the exchanger
in parts (37*10 + 5*1).

* Made Heat Exchanger process arbitrary amounts of fluid.

* Added entry to changelog.

(cherry picked from commit b952a7d)

@AEnterprise AEnterprise closed this May 6, 2018

@Bigdbigd03

This comment has been minimized.

Copy link

Bigdbigd03 commented Sep 12, 2018

This issue looks like a mess. Wow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.