New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No close GUI DUPE (duplicate glitch all blocks) #4138

Closed
bigenergy opened this Issue Apr 22, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@bigenergy

bigenergy commented Apr 22, 2018

BuildCraft version: BuildCraft 7.99.16 1.12.2
Forge version: 2655
Link to crash report or log: no crash
Singleplayer or multiplayer: multiplayer
Steps to reproduce: All BuildCraft blocks that have a GUI Interface do not close the GUI.
Additional information: You put a block that has a GUI interface, go into it, meanwhile your friend breaks this block, and the interface of this block remains open for you.

@bigenergy

This comment has been minimized.

bigenergy commented Apr 22, 2018

@bigenergy bigenergy changed the title from No close GUI DUPE to No close GUI DUPE (duplicate glitch all blocks) Apr 22, 2018

@AlexIIL

This comment has been minimized.

Member

AlexIIL commented Apr 22, 2018

Ok, so the issue is that you can break the block and still access the inventory. I think I've seen a similar report / fix in forge, so this sort of dupe glitch is probably already known.

@bigenergy

This comment has been minimized.

bigenergy commented Apr 22, 2018

Are you sure this is a forge problem? On other mods there is no such.

@AlexIIL

This comment has been minimized.

Member

AlexIIL commented Apr 22, 2018

No, not a bug in forge. I've seen a very similar bug report somewhere else, I'm not sure where though :/

AlexIIL added a commit that referenced this issue Apr 22, 2018

@AlexIIL

This comment has been minimized.

Member

AlexIIL commented Apr 22, 2018

Ok, looks like this is caused by incorrectly overriding canInteractWith in every single container... This shouldn't be too difficult to fix then. (The previous commit fixed another dupe glitch where blocks exploded with TNT or another explosion would drop their inventory... twice.

@AlexIIL

This comment has been minimized.

Member

AlexIIL commented Apr 23, 2018

Ok, this should be fixed in 7.99.17-pre1 on the tests page.

Tencao added a commit to Tencao/BuildCraft that referenced this issue Apr 27, 2018

Tencao added a commit to Tencao/BuildCraft that referenced this issue Apr 27, 2018

Fix BuildCraft#4138
(cherry picked from commit 7faa15c)

@AEnterprise AEnterprise closed this May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment