New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintuitive cross-module recipe dependencies #4141

Open
Firnagzen opened this Issue Apr 23, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@Firnagzen

Firnagzen commented Apr 23, 2018

BuildCraft version: 7.99.16
Forge version: Not relevant
Link to crash report or log: -nil-
Singleplayer or multiplayer: Both
Steps to reproduce: Open JEI and look at the recipes for various items, for example pipe plugs and lasers.
Additional information:
Several items appear to not have recipes, including in the guide book, and moreover, these are recipes that do not require the assembly table to be crafted. It appears that this is because their recipes have the condition:

  "conditions": [
    {
      "type": "minecraft:item_exists",
      "item": "buildcraftbuilders:quarry"
    }
  ]

in them as seen here and here. However, these items do not functionally depend on the quarry, and Buildcraft Builders may not be expected to be installed eg. when only a piping system is required. I'm aware that the pipe plug has just been fixed, however, I'm flagging this as an issue as there may be further recipes with odd dependencies.

@AEnterprise

This comment has been minimized.

Member

AEnterprise commented Apr 23, 2018

seems i messed up with copy pasting conditionals, those recipes do need conditionals, just for other items (their components from BC iteslf for in case someone dissables it or doesn't have that module), this is to prevent that recipe from erroring and killing the registration of the other recipes

@AlexIIL AlexIIL closed this in 6f5a6f4 Apr 23, 2018

@AlexIIL AlexIIL reopened this Apr 23, 2018

Tencao added a commit to Tencao/BuildCraft that referenced this issue Apr 27, 2018

Fix the pipe blocker requiring the quarry. Instead, make it depend on…
… the structure pipe. Partially fixes BuildCraft#4141.

(cherry picked from commit 6f5a6f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment