Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildCraft breaks CTM mod #4238

Open
seancrain opened this issue Jul 27, 2018 · 13 comments

Comments

Projects
None yet
3 participants
@seancrain
Copy link

commented Jul 27, 2018

BuildCraft version: 7.99.17
Forge version: 14.23.4.2739
Link to crash report or log: https://www.nosiphus.com/minecraft/crash-reports/latest.log
Singleplayer or multiplayer: both
Steps to reproduce:
Download the following:
https://minecraft.curseforge.com/projects/ctm/files/2584026
https://bdcraft.net/downloads/purebdcraft-minecraft/#dl-112 - 128x
https://drive.google.com/uc?authuser=0&id=1eNCIwpAJSZ_LXvacb--F-3oSnHS8Yrr3&export=download
Additional information: CTM mod version 1.12.2-0.3.2.18

I put together a CTM patch for PureBDcraft a while ago. The patch does not have anything related to BuildCraft in it at all, and works normally when BC is not present:

working

However, if BuildCraft is added to the environment, this happens:

not functional

@AlexIIL

This comment has been minimized.

Copy link
Member

commented Jul 27, 2018

Do only the gold and iron blocks that don't work? Or do other blocks also not work?

@seancrain

This comment has been minimized.

Copy link
Author

commented Jul 27, 2018

As far as I know, iron and gold are the only two that have rendering issues. What's funny is the diamond and emerald connected textures utilize the same method and work completely fine. So do the stained clay textures.

Forge Multipart microblocks did have errors with the wood textures, but I don't know what exactly caused that, and I can't remember if that was solved before or after I removed BuildCraft from the testing environment.

@seancrain

This comment has been minimized.

Copy link
Author

commented Jul 28, 2018

Diamonds started malfunctioning.

@AEnterprise

This comment has been minimized.

Copy link
Member

commented Jul 28, 2018

can you provide a log from when this happens? maybe that has some clues on what is going on here

@seancrain

This comment has been minimized.

Copy link
Author

commented Jul 28, 2018

Also, we (Nosiphus) use BuildCraft and CTM as part of our modpack, Telkit. I'll place a link here if you want to test it and see if something else is causing it, although I'm fairly certain BuildCraft is to blame due to the circumstances described in the top post. https://www.nosiphus.com/minecraft/telkit.html

@seancrain

This comment has been minimized.

Copy link
Author

commented Aug 11, 2018

So, I decided to revisit the issue, and I loaded an environment with Forge 2749, BuildCraft 7.99.17, BuildCraft Compat 7.99.14, and CTM-MC1.12.2-0.3.2.18.

This was the result:

All four of them

I disabled Animated Sprites and the OptiFine performance fix option, thinking it may have also conflicted with CTM somehow, but that did not solve the problem. Emerald blocks also use the same method as diamond, and yet one works and the other doesn't.

Any heads up on what's been going on since I was last here?

@AlexIIL

This comment has been minimized.

Copy link
Member

commented Aug 11, 2018

I think this might be todo with that fact that buildcraft gates depend on a few of the vanilla textures for the gate edges: https://github.com/BuildCraft/BuildCraft/blob/8.0.x/buildcraft_resources/assets/buildcraftsilicon/models/plugs/gate.json.

To test this can you either (a) make a resource pack with that json file changed to use different textures or (b) rename the "gate.json" file in the BC jar file to "gate.json.backup" to see if removing it fixes the issue?

@seancrain

This comment has been minimized.

Copy link
Author

commented Aug 11, 2018

That corrected the issue for diamond and iron, but gold remains broken. I will create overrides for that file as part of the patch.

All I need to know is where the base gold texture is referenced.

@seancrain

This comment has been minimized.

Copy link
Author

commented Aug 11, 2018

Edit: I found the other file (it was stripes.json in the buildcrafttransport folder), and I have fixed the issue.

@seancrain seancrain closed this Aug 11, 2018

@AlexIIL

This comment has been minimized.

Copy link
Member

commented Aug 11, 2018

No, it's still an issue, that was just to see if that causes it.

@AlexIIL AlexIIL reopened this Aug 11, 2018

@AlexIIL

This comment has been minimized.

Copy link
Member

commented Aug 11, 2018

Erm, how specifically are you fixing it? Are you replacing the texture, or so you create a separate texture specifically for CTM?

@seancrain

This comment has been minimized.

Copy link
Author

commented Aug 11, 2018

I was unsure over whether to close it either. Here's how I fixed the file.

I first took the non-CTM textures and placed them into a subfolder. I am unsure of how this falls under the BDcraft license, while the CTM addon itself is okay, I already had a discussion with HanFox, the lead moderator of the forum, I sent a private message to him just a few minutes ago about the BuildCraft workaround.

Then, I took the problematic JSON files, added the subfolder directory to their texture mappings and then included them as overrides in the patch. While it does correct the problem on the surface, the underlying issue remains, it's just that the remapped files don't direct to problem-causing files.

I think what might be happening is that when it tries to load the base texture from its original location, it sees the JSON file directing the CTM mod to load the connected textures. Since BC doesn't support the CTM api, it gets confused and therefore neither mod will load the correct texture. That's my theory, it's likely not correct at all.

You might want to talk to @tterrag1098 for more information about this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.