New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidebook lag #4249

Closed
deusversus opened this Issue Aug 15, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@deusversus

deusversus commented Aug 15, 2018

I can't open the guidebook without a lagspike; the client freezes for about 15-20 seconds before opening the guidebook.

BuildCraft version: 7.99.17
Forge version: 2747
Link to crash report or log: n/a
Singleplayer or multiplayer: Multiplayer
Steps to reproduce: Open the Guidebook
Additional information: n/a

@Bigdbigd03

This comment has been minimized.

Bigdbigd03 commented Aug 16, 2018

For me it's about 2-5 seconds, but it is a thing.

@Bigdbigd03

This comment has been minimized.

Bigdbigd03 commented Aug 16, 2018

I opened it about 4 times in 2 worlds.

@AlexIIL

This comment has been minimized.

Member

AlexIIL commented Aug 16, 2018

I'm not entirely sure where the performance issue is so I'll add some profiling to 7.99.18-pre1 and then ask you to send the resulting profiler logs back here. It will probably take a few days to come out though.

@AlexIIL

This comment has been minimized.

Member

AlexIIL commented Aug 16, 2018

After a bit of analysis it looks like it scans the item and statement registries everytime you open the gui, and populates a search object, which takes up quite a while. I'll try moving that code to the main reload() sequence to see if that speeds it up a bit.

@AlexIIL

This comment has been minimized.

Member

AlexIIL commented Aug 19, 2018

This should be fixed in the 7.99.18-pre1 prerelease, or you can wait until 7.99.18 itself gets released.

@deusversus

This comment has been minimized.

deusversus commented Aug 19, 2018

Many thanks.

@AlexIIL AlexIIL closed this Sep 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment