Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oil gen in dimensions config typo #4469

Closed
xJon opened this issue Aug 15, 2019 · 1 comment
Closed

Oil gen in dimensions config typo #4469

xJon opened this issue Aug 15, 2019 · 1 comment
Labels
complexity: simple This can be implemented quickly and easily. type: bug Something isn't behaving as expected, from a developer perspective. (Except crashes are always bugs) version: 1.12.2

Comments

@xJon
Copy link

xJon commented Aug 15, 2019

Please complete the following information:

  • Forge Version: 1.12.2-14.23.5.2838
  • BuildCraft Version: 7.99.24.2

To Reproduce
Steps to reproduce the behavior:

  1. Generate config file

The config file of the mod regarding oil gen in dimensions looks like this:

        # Dimension ID's (e.g. '-1' for the nether,'1' for the end) of dimensions that should never generate oil.
        I:excludedDimensions <
            -1
            1
         >

        # If true then the excluded biomes list will be treated as a blacklist, otherwise it will be treated as a whitelist.
        B:excludedDimensionsIsBlacklist=true

There is a typo in the second config, as it should exclude dimensions and not biomes, but also maybe this could be written better? Because even if the second config is set to false the first config is still described as a blacklist, which could be confusing.

@xJon xJon added the auto: bug This issue was based on the "bug" issue type, and hasn't been looked at yet. label Aug 15, 2019
@AlexIIL AlexIIL added complexity: simple This can be implemented quickly and easily. type: bug Something isn't behaving as expected, from a developer perspective. (Except crashes are always bugs) version: 1.12.2 and removed auto: bug This issue was based on the "bug" issue type, and hasn't been looked at yet. labels Aug 15, 2019
@AlexIIL
Copy link
Member

AlexIIL commented Dec 4, 2019

Ok, this should be implemented in 7.99.24.4.

@AlexIIL AlexIIL closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: simple This can be implemented quickly and easily. type: bug Something isn't behaving as expected, from a developer perspective. (Except crashes are always bugs) version: 1.12.2
Projects
None yet
Development

No branches or pull requests

2 participants