Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable biomes (and worldgen layer) #4511

Closed
adosikas opened this issue Dec 2, 2019 · 2 comments
Closed

Option to disable biomes (and worldgen layer) #4511

adosikas opened this issue Dec 2, 2019 · 2 comments
Labels
status: fixed/implemented in dev We've fixed this internally, however the fix hasn't been released publicly yet. type: enhancement Something small that would improve buildcraft version: 1.12.2

Comments

@adosikas
Copy link

adosikas commented Dec 2, 2019

Is your feature request related to a problem? Please describe.
Currently there is no way of disabling the custom oil biomes without completely disabling worldgen (and with it all oil deposits).
In old BuildCraft this was possible by setting the biome ids to 0 link.

Describe the solution you'd like
Add config option to disable the oil biomes, optionally make the spawn rate configurable.
Also don't add the world gen layer when the biomes are disabled (similar to setting biome ID to 0 in old BuildCraft).

Full disclosure: My primary reason is that the added worldgen layers currently cause inconviences with RTG (Issue).

Obviously that problem is not a BuildCraft issue and should be fixed on RTGs end, but regardless of that, I can still see uses for a config options for the biomes.
@adosikas adosikas added the auto: feature This issue was based on the "feature" issue type, and hasn't been looked at yet. label Dec 2, 2019
@adosikas adosikas changed the title Option to disable biomes/Worldgen layer Option to disable biomes (and worldgen layer) Dec 2, 2019
@AlexIIL AlexIIL added type: enhancement Something small that would improve buildcraft version: 1.12.2 and removed auto: feature This issue was based on the "feature" issue type, and hasn't been looked at yet. labels Dec 4, 2019
@AlexIIL AlexIIL self-assigned this Dec 4, 2019
@AlexIIL
Copy link
Member

AlexIIL commented Dec 4, 2019 •
edited
Loading

Sounds like a good idea :)

AlexIIL added a commit that referenced this issue Dec 4, 2019
@AlexIIL
Two changes:
a03238d 
* Implemented the config option for #4511 (allowed disabling the desert and ocean biomes)
* Tweaked the minimum guide item count down from 5k to 1.5k
@AlexIIL AlexIIL removed their assignment Dec 4, 2019
@AlexIIL AlexIIL added the status: fixed/implemented in dev We've fixed this internally, however the fix hasn't been released publicly yet. label Dec 4, 2019
@AlexIIL
Copy link
Member

AlexIIL commented Dec 4, 2019

Ok, this should be implemented in 7.99.24.4.

@AlexIIL AlexIIL closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: fixed/implemented in dev We've fixed this internally, however the fix hasn't been released publicly yet. type: enhancement Something small that would improve buildcraft version: 1.12.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adosikas @AlexIIL