Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug when filling machine fill rotated solid 2d shape #4527

Open
fffasttime opened this issue Feb 11, 2020 · 3 comments
Open

Small bug when filling machine fill rotated solid 2d shape #4527

fffasttime opened this issue Feb 11, 2020 · 3 comments
Labels
auto: bug

Comments

@fffasttime
Copy link

fffasttime commented Feb 11, 2020

Please complete the following information:

  • Forge Version: -
  • BuildCraft Version (Add Hash if from github): 7.99.24.4
  • Any additonal mods: -

To Reproduce
Steps to reproduce the behavior:

  1. Set a filling machine on "arc", "90 degree", "solid" mode
  2. See bug: the result pattern is not solid

I read code in PatternShape2d.java, at


The beginning point of filling isn't poperly rotated

@fffasttime fffasttime added the auto: bug label Feb 11, 2020
@AlexIIL
Copy link
Member

AlexIIL commented Feb 23, 2020

Ok, this should be fixed in 7.99.24.5 - please let me know if that's not the case.

@fffasttime
Copy link
Author

fffasttime commented Mar 6, 2020

Now it works correctly on square region.

@fffasttime
Copy link
Author

fffasttime commented Mar 6, 2020

Oh, this problem still exists on rectangle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto: bug
Projects
None yet
Development

No branches or pull requests

2 participants