Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuideManager causes game crash if Crafttweaker tries to remove item tooltips. #4530

Closed
plackyfantacky opened this issue Feb 20, 2020 · 4 comments
Assignees
Labels
type: bug type: mod compat version: 1.12.2

Comments

@plackyfantacky
Copy link

plackyfantacky commented Feb 20, 2020

Crash report

Tested this with two instances (One with a pack I'm developing, another with bare essentials to reproduce the crash).

It seems I am able to repeatedly crash Buildcraft if I try and remove tooltips from an item using CraftTweaker like so:

<galacticraftplanets:walkway:1>.clearTooltip();

I thought it was my code or a CT issue at first but seems to only happen with BC. I'm following CT documentation for a pack I'm making. Here is my ZS file that triggers the GuideManager crash, and here is the related CT documentation.

Sorry to beat a dead horse but can we please have a config option to disable the in-game Guide?

@plackyfantacky plackyfantacky added the auto: crash label Feb 20, 2020
@AlexIIL
Copy link
Member

AlexIIL commented Feb 20, 2020

@plackyfantacky
Copy link
Author

plackyfantacky commented Feb 20, 2020

Fair enough. This was mostly an example, but in terms of what I'm doing, I am re-writing a lot of the tooltips to fit in the lore/theme of the pack I'm developing. I just remove the existing tooltip, then add in my own.

@AlexIIL
Copy link
Member

AlexIIL commented Feb 20, 2020

Ah ok, that would make more sense.

@AlexIIL AlexIIL added type: bug type: mod compat version: 1.12.2 and removed auto: crash labels Feb 20, 2020
@AlexIIL AlexIIL self-assigned this Feb 20, 2020
@AlexIIL
Copy link
Member

AlexIIL commented Feb 23, 2020

Ok, this should be fixed in 7.99.24.5 - please let me know if that's not the case.

@AlexIIL AlexIIL closed this as completed Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug type: mod compat version: 1.12.2
Projects
None yet
Development

No branches or pull requests

2 participants