New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config option to change the max water pumping distance. #3964

Merged
merged 3 commits into from Jan 7, 2018

Conversation

Projects
None yet
3 participants
@Yuki-nyan
Contributor

Yuki-nyan commented Jan 7, 2018

I decided to add this option for myself since I wanted to drain an Ocean Monument using a bunch of pumps around the perimeter and a finite water mod - it makes this possible but has a huge effect on performance when increased much above 64 as you might expect. If you don't want to merge this I'll just maintain my own fork 馃槃

@AlexIIL

Looks good! Few minor things that probably want changing.

@AlexIIL

AlexIIL approved these changes Jan 7, 2018

@AlexIIL AlexIIL merged commit e178631 into BuildCraft:8.0.x Jan 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AEnterprise

This comment has been minimized.

Show comment
Hide comment
@AEnterprise

AEnterprise Jan 13, 2018

Member

forgot to put this here earlier, if you are on the discord (or join in the future) you can get the contributor role for this PR, to get it reply here with your discord username and discriminator

Member

AEnterprise commented Jan 13, 2018

forgot to put this here earlier, if you are on the discord (or join in the future) you can get the contributor role for this PR, to get it reply here with your discord username and discriminator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment