Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow oredicted ItemStacks with stacksizes greater than 1 #4618

Merged
merged 4 commits into from Nov 27, 2021

Conversation

glowredman
Copy link

@glowredman glowredman commented Nov 21, 2020

Affects buildcraft.core.recipes.FlexibleRecipe#setContents().

This change is backwardscompatible and fullfills this promise:
grafik

I was not able to build the jars, even with a fresh clone. It always crashes at :javadoc. Maybe this log of gradlew build --stacktrace --info --debug can help with that...
When I removed the javadoc tasks, after that, it built as expected.

@AlexIIL AlexIIL added type: enhancement Something small that would improve buildcraft version: 1.7.10 labels Dec 4, 2020
@asiekierka asiekierka self-assigned this Dec 16, 2020
Copy link
Member

@asiekierka asiekierka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this, looks good to me - and will be merged. Though I can give no promises on an official update... long out of my jurisdiction.

common/buildcraft/core/recipes/FlexibleRecipe.java Outdated Show resolved Hide resolved
@asiekierka
Copy link
Member

@AlexIIL feel free to merge whenever, and/or do something with the checkstyle, this is good to me

@asiekierka asiekierka merged commit a6f381f into BuildCraft:7.1.x Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Something small that would improve buildcraft version: 1.7.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants