Added .getExactPermission() method in PermissionAttachmentInfo to get original cased permissions #586

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
4 participants

NodiusC commented Apr 21, 2012

This allows developers to get original cased permissions (as in exactly how users typed them in permissions plugin's configs / exactly how developers set them in PermissionAttachments) and will not break Bukkit's permission system nor will it break plugins. Very useful if a plugin were to parse permissions for some info unknown at start.

The TestPlugin that I used to test and its source can be found here and here respectively.

Contributor

zml2008 commented Apr 21, 2012

You should avoid changing line endings in the same commit as other non-formatting changes
Also, you should't post unofficial CB builds in PR's (or anywhere)

NodiusC commented Apr 21, 2012

Ah, okay, let me remove the link.

Also, what did you mean by "changing line endings in the same commit"?

Contributor

zml2008 commented Apr 21, 2012

ExpBottleEvent, PotionSplashEvent, SheepRegrowWoolEvent, PlayerVelocityEvent, and TestEnchantment all have their line endings changed in your PR. While the change is correct, it should be in a separate commit to keep actual code changes separate.

NodiusC commented Apr 21, 2012

Well, I don't know. I never touched them, Github just thinks that I changed something. :/

Github always think that I commited something even though I didn't. :/

drantor commented Apr 21, 2012

What Editor do you use?

NodiusC commented Apr 22, 2012

Eclipse.

NodiusC commented Apr 22, 2012

Fixed it.

With this bunch of commits, I might as well redo the pull request? :|

zerg960 commented Apr 22, 2012

Someone once told me about "force push" squashing commits.

NodiusC closed this Apr 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment