Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update src/main/java/org/bukkit/event/Event.java #592

Closed
wants to merge 1 commit into from

5 participants

@petterroea

It wrong method name?

@Top-Cat

I'm not sure you can say a method name is wrong and as this is in the api (bukkit) changing it is likely to do more harm than good.

@gmcferrin

Yeah... no. There's no such thing as the "wrong" method name, unless you're using the wrong name when calling it in your code. This method could be called "getAllTheHandlersForThisEvent" and would still be just as "right".

@jrtc27

Agreed. The method name is plural, implying some form of array/list being returned. This is a breaking change without much point to it,

@feildmaster
Collaborator

This breaks many plugins, and will not be renamed. The current name is fine.

@petterroea

(Sorry, found the error that caused me to trace back and find this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 23, 2012
  1. Update src/main/java/org/bukkit/event/Event.java

    petterroea authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/main/java/org/bukkit/event/Event.java
View
2  src/main/java/org/bukkit/event/Event.java
@@ -16,7 +16,7 @@ public String getEventName() {
return name;
}
- public abstract HandlerList getHandlers();
+ public abstract HandlerList getHandlerList();
public enum Result {
Something went wrong with that request. Please try again.