Check null before grabbing owning plugin - fixes BUKKIT-3987 #843

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

AlphaBlend commented Apr 5, 2013

The null validation check comes after the owning plugin is extracted from it, resulting in a possible NPE if a null value is passed to the method.

The issue:

A validation check is called to make sure that the metadata value passed in is not null. However, another call, which gets the owning plugin of the metadata value, gets called before this validation check is called, resulting in an NPE if the value passed into the method is null.

Bukkit Ticket:

BUKKIT-3987: https://bukkit.atlassian.net/browse/BUKKIT-3987

Member

turt2live commented Jul 29, 2013

As sad as it sounds, can testing material be provided for this?

And can this be modified to follow the CONTRIBUTING.md file please?

Contributor

Wolvereness commented Aug 7, 2013

Wolvereness closed this Aug 7, 2013

AlphaBlend deleted the AlphaBlend:CheckNullFirst branch Dec 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment