Uninstall leaves blacklist in /etc/modprobe.d/bumblebee.conf #525

Closed
xEtherealx opened this Issue Jan 17, 2014 · 12 comments

Projects

None yet

4 participants

@xEtherealx

Title says it all. I'm on Mint 16 and used apt-get remove to uninstall, after which my driver wouldn't load. After digging around, it turns out the driver was blacklisted in the bumblebee.conf file! Most likely, removal of this should be part of the uninstallation process.

@Lekensteyn
Bumblebee-Project member

Configuration files are preserved unless you purge a package:

sudo apt-get purge bumblebee
@Lekensteyn Lekensteyn closed this Jan 17, 2014
@xEtherealx

Is that reasonable in this case? I would argue that system configuration files should be removed upon uninstallation in order to avoid the issue that I just experienced.

@Lekensteyn
Bumblebee-Project member

@Vincent-C What do you think about this?

@Lekensteyn Lekensteyn reopened this Jan 17, 2014
@Vincent-C
Bumblebee-Project member

Well, what I think doesn't matter all that much, since I'm not a dpkg/apt developer. :) (But for the record, I do think that apt-get is taking the right course of action by preserving conffiles on remove and not purge, and that the distinction between apt-get remove and apt-get purge is important.)

That being said, with issues like this and the recent xorg-edgers nvidia-package-depending-on-bumblebee debacle, we may just want to not treat /etc/modprobe.d/bumblebee.conf as a dpkg conffile, e.g. create that file manually during postinst and remove it in prerm. See also maint-guide 5.3.

Thoughts? @ArchangeGabriel ?

@Lekensteyn
Bumblebee-Project member

@Vincent-C I was asking since you maintain the Debian package. In general it is sane to preserve configuration files.

However, this modprobe conf file has severe side-effects when installed, so I favor your proposal to remove it in the postinst script.

@ArchangeGabriel
Bumblebee-Project member

First of all, I think this should be reported to bumblebee-ppa and not Bumblebee.

Then, I agree with @Vincent-C, this should be let to the purge action.

Do we change this to avoid users not behaving correctly is the question. Is there some place we could ask apt or debian developers about this?

@Vincent-C
Bumblebee-Project member

There are some mailing lists that you could ask for feedback on this, e.g. debian-dpkg@lists.debian.org if you wanted to contact the dpkg developers, but personally I doubt that'd be helpful in this case, since there aren't that many options for us to choose from (either /etc/modprobe.d/bumblebee.conf is a conffile, or it's not).

I'll take a stab at implementing this soon-ish (hopefully before ubuntu's debian import freeze).

@ArchangeGabriel ArchangeGabriel self-assigned this Apr 2, 2014
@Lekensteyn
Bumblebee-Project member

Ok, giving it another thought, I think that the modprobe conf file should be removed. From a user's thought:

  • purge should remove everything, leaving no trace of the package
  • remove should remove the program, but leave the conffiles behind in case the user wants to install the binaries again at a later stage.

Users should not touch the /etc/modprobe.d/bumblebee.conf file, so it should be safe to remove the file on remove.

@Vincent-C Vincent-C added a commit to Bumblebee-Project/bumblebee-ppa that referenced this issue Oct 25, 2014
@Vincent-C Vincent-C all/bumblebee: Stop treating /etc/modprobe.d/bumblebee.conf as a conf…
…file and remove it when removing bumblebee (LP: #1242785, and Bumblebee-Project/Bumblebee#525)
807436d
@Vincent-C
Bumblebee-Project member

Fixed in Bumblebee-Project/bumblebee-ppa@807436d

@Lekensteyn or @ArchangeGabriel, are either of you going to update the PPA, or would you be comfortable with making me a member of the bumblebee launchpad project so I can prepare new packages myself?

@Lekensteyn
Bumblebee-Project member

@Vincent-C I have added you as a team member, you should have permissions to upload now. Before uploading a new package, see also #319.

@ArchangeGabriel
Bumblebee-Project member

Hi @Vincent-C and @Lekensteyn!

I’m having no time left for updating these packages currently, so feel free to take up the maintaining of them.

Concerning the issue here, I indeed agree that what we should consider as conf files are the things in /etc/bumblebee, the modprobe file is just a thing to fix some issues that the user is not expected to edit.

So, closing this since it has been implemented in the right place.

@Vincent-C
Bumblebee-Project member

@Lekensteyn, thanks! I guess there's no rush to push out updated packages for the PPA, so I'll wait on a new release and follow the discussion at #319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment