check for power state only on x86 and arm64 #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnox
reviewed
Nov 23, 2021
xnox
suggested changes
Nov 24, 2021
arighi
force-pushed
the
arighi
branch
2 times, most recently
from
103b2ae
to
494d20e
Compare
In bbswitch_off() we use acpi_bus_get_device() to determine the power state, but this feature is only available if ACPI is enabled in the kernel, so make sure to do this check only when ACPI is available. Fixes: 5593d95 ("Linux 3.8 compatibility hack") Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bbswitch_off() we use acpi_bus_get_device() to determine the power
state, but this feature is only available on x86 and arm64, so make sure
to do this check only on the relevant architectures to prevent build
errors.
Fixes: 5593d95 ("Linux 3.8 compatibility hack")
Signed-off-by: Andrea Righi andrea.righi@canonical.com