New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in GET requests #266

Closed
jgayfer opened this Issue Oct 26, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@jgayfer

jgayfer commented Oct 26, 2017

I'm running into problems looking for accounts with special characters in their names.

Example
Username: Grëëm#1623

https://www.bungie.net/Platform/Destiny2/SearchDestinyPlayer/4/Gr%C3%AB%C3%ABm%231623

I'm pretty sure I'm encoding this properly, but I may not be. Wondering if anyone here has any suggestions on how I can continue.

Note that this username is from one of my users, and haven't explicitly confirmed that he has played the game on PC yet, but I am 99.5% sure that he has.

@vthornheart-bng

This comment has been minimized.

Show comment
Hide comment
@vthornheart-bng

vthornheart-bng Oct 26, 2017

Contributor

Hmm, interesting! Yeah, URL Encoding should have done the trick... very interesting.

Could you have them send you a link to their profile page on bungie.net, and then link it here? That will give us some info.

Contributor

vthornheart-bng commented Oct 26, 2017

Hmm, interesting! Yeah, URL Encoding should have done the trick... very interesting.

Could you have them send you a link to their profile page on bungie.net, and then link it here? That will give us some info.

@jgayfer

This comment has been minimized.

Show comment
Hide comment

jgayfer commented Oct 26, 2017

@vthornheart-bng

This comment has been minimized.

Show comment
Hide comment
@vthornheart-bng

vthornheart-bng Oct 26, 2017

Contributor

Welp, this is going to be an interesting mystery, I'll have to chase down the root cause but for some reason his name has been encoded according to our search as:

Grëëm#1623

... ugh.

I don't know why yet, so I don't have a workaround I can provide aside from the very specific situation that for some reason umlats are being converted to ë... I'll have to get back to you on this once I talk to some folks over here.

(Of course it's an encoding issue... I just don't know where in our pipeline it's falling over. I'll have to do some digging, this may take a bit)

Contributor

vthornheart-bng commented Oct 26, 2017

Welp, this is going to be an interesting mystery, I'll have to chase down the root cause but for some reason his name has been encoded according to our search as:

Grëëm#1623

... ugh.

I don't know why yet, so I don't have a workaround I can provide aside from the very specific situation that for some reason umlats are being converted to ë... I'll have to get back to you on this once I talk to some folks over here.

(Of course it's an encoding issue... I just don't know where in our pipeline it's falling over. I'll have to do some digging, this may take a bit)

@jgayfer

This comment has been minimized.

Show comment
Hide comment
@jgayfer

jgayfer Oct 26, 2017

Interesting. Thanks for getting back to me promptly! Don't work too hard though, it's getting late here on the west coast ;)

jgayfer commented Oct 26, 2017

Interesting. Thanks for getting back to me promptly! Don't work too hard though, it's getting late here on the west coast ;)

@vthornheart-bng

This comment has been minimized.

Show comment
Hide comment
@vthornheart-bng

vthornheart-bng Oct 26, 2017

Contributor

^_^ No prob! I had to hit up some folks to get more info about potential upstream causes, and I'm not sure when they'll reply... so I might not have more info for a bit unfortunately. But I'll update here once I get more info. In the meantime, the hacky thing that comes to my mind is to try and convert the incoming UTF-8 to Windows-1252, this is what I heavily suspect is happening somewhere in our pipeline, so doing that should result in you passing characters that it recognizes for the string matching. Yuck. If the problem turns out to be upstream of us, we may end up having to do the same thing to at least start returning responses for these folks. Hopefully it's not upstream... I need some time to investigate further on our side. Fun times... glad you reported this!

Contributor

vthornheart-bng commented Oct 26, 2017

^_^ No prob! I had to hit up some folks to get more info about potential upstream causes, and I'm not sure when they'll reply... so I might not have more info for a bit unfortunately. But I'll update here once I get more info. In the meantime, the hacky thing that comes to my mind is to try and convert the incoming UTF-8 to Windows-1252, this is what I heavily suspect is happening somewhere in our pipeline, so doing that should result in you passing characters that it recognizes for the string matching. Yuck. If the problem turns out to be upstream of us, we may end up having to do the same thing to at least start returning responses for these folks. Hopefully it's not upstream... I need some time to investigate further on our side. Fun times... glad you reported this!

@floatingatoll

This comment has been minimized.

Show comment
Hide comment
@floatingatoll

floatingatoll Oct 26, 2017

floatingatoll commented Oct 26, 2017

@bladefist

This comment has been minimized.

Show comment
Hide comment
@bladefist

bladefist Oct 26, 2017

I'm seeing Chinese/Japanese and other languages that use unicode not working as well. I'm assuming this is the same issue?

bladefist commented Oct 26, 2017

I'm seeing Chinese/Japanese and other languages that use unicode not working as well. I'm assuming this is the same issue?

@Tetron-bng

This comment has been minimized.

Show comment
Hide comment
@Tetron-bng

Tetron-bng Oct 27, 2017

The display names for Battle.net accounts getting stored in a corrupted state in our database and so search will not be able to find them. A fix is in the works but no ETA.

Tetron-bng commented Oct 27, 2017

The display names for Battle.net accounts getting stored in a corrupted state in our database and so search will not be able to find them. A fix is in the works but no ETA.

@Tetron-bng

This comment has been minimized.

Show comment
Hide comment
@Tetron-bng

Tetron-bng Nov 10, 2017

This issue has been resolved. The user's display name will continue to be garbled until they sign into the game.

Tetron-bng commented Nov 10, 2017

This issue has been resolved. The user's display name will continue to be garbled until they sign into the game.

@Tetron-bng Tetron-bng closed this Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment