New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write tests #3

Closed
BurntSushi opened this Issue Jul 23, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@BurntSushi
Owner

BurntSushi commented Jul 23, 2016

No description provided.

@Apanatshka

This comment has been minimized.

Show comment
Hide comment
@Apanatshka

Apanatshka Jul 26, 2016

Contributor

Did you have anything specific in mind here?

Contributor

Apanatshka commented Jul 26, 2016

Did you have anything specific in mind here?

@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Jul 26, 2016

Owner

Unit tests:

  • Test the benchmark parser, including the fact that throughput is optional.
  • Test that find overlap finds the correct pairs.
  • Test that find overlap reports correct missing benchmarks (for both old and new).
  • Test that the name determination for the two columns works correctly when given two file paths. (This may require refactoring the names method off of the Args struct.)
  • Test commafy.

Integration tests:

  • Test some basic example inputs and check that it produces the expected output.
  • Test that the name prefix feature works. (Possibly also refactor code into a unit test.)
  • Test that passing input on stdin works.

There may be others but this is all I've got off the top of my head at the moment. Bonus points if we can use quickcheck.

Owner

BurntSushi commented Jul 26, 2016

Unit tests:

  • Test the benchmark parser, including the fact that throughput is optional.
  • Test that find overlap finds the correct pairs.
  • Test that find overlap reports correct missing benchmarks (for both old and new).
  • Test that the name determination for the two columns works correctly when given two file paths. (This may require refactoring the names method off of the Args struct.)
  • Test commafy.

Integration tests:

  • Test some basic example inputs and check that it produces the expected output.
  • Test that the name prefix feature works. (Possibly also refactor code into a unit test.)
  • Test that passing input on stdin works.

There may be others but this is all I've got off the top of my head at the moment. Bonus points if we can use quickcheck.

@Apanatshka Apanatshka referenced this issue Aug 6, 2016

Merged

Tests #10

8 of 8 tasks complete
@Apanatshka

This comment has been minimized.

Show comment
Hide comment
@Apanatshka

Apanatshka Sep 27, 2016

Contributor

Given #10 and #13, can we close this?

Contributor

Apanatshka commented Sep 27, 2016

Given #10 and #13, can we close this?

@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Sep 27, 2016

Owner

Oh yes indeed! Thanks so much. :-)

Owner

BurntSushi commented Sep 27, 2016

Oh yes indeed! Thanks so much. :-)

@BurntSushi BurntSushi closed this Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment