New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossbeam-channel – EOL chan #25

Closed
jnicholls opened this Issue Nov 27, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@jnicholls

jnicholls commented Nov 27, 2017

#@BurntSushi I would suggest checking out crossbeam-channel and if you feel it's a replacement for chan, point people to it in your README to defragment the mpmc situation a little bit. Thanks for all you do.

@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Nov 27, 2017

Owner

I haven't tried it yet, but yeah, when I do, if I think it sufficiently replaces this crate then I would be happy to retire it and point folks to crossbeam-channel. I suspect my three biggest concerns are this:

  1. What does writing a select look like?
  2. Do channels block or are they constantly spinning?
  3. I will probably want a replacement for chan-signal, although I suspect that would be easy enough to build on crossbeam-channel.

I'm on mobile, so I haven't done my due diligence on the above concerns.

Owner

BurntSushi commented Nov 27, 2017

I haven't tried it yet, but yeah, when I do, if I think it sufficiently replaces this crate then I would be happy to retire it and point folks to crossbeam-channel. I suspect my three biggest concerns are this:

  1. What does writing a select look like?
  2. Do channels block or are they constantly spinning?
  3. I will probably want a replacement for chan-signal, although I suspect that would be easy enough to build on crossbeam-channel.

I'm on mobile, so I haven't done my due diligence on the above concerns.

@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Nov 27, 2017

Owner

Okay, I just read the crate docs and I'm super impressed. It seems all of my concerns are satisfied. I'll give it a try in my cmail and fst commands, and assuming all goes well, I'll EOL chan.

Owner

BurntSushi commented Nov 27, 2017

Okay, I just read the crate docs and I'm super impressed. It seems all of my concerns are satisfied. I'll give it a try in my cmail and fst commands, and assuming all goes well, I'll EOL chan.

@stjepang

This comment has been minimized.

Show comment
Hide comment
@stjepang

stjepang Nov 27, 2017

I'll give it a try in my cmail and fst commands

Please do! If you have any feedback, let me know. :)

So far I've written a fairly extensive suite of unit tests and managed to switch Servo from mpsc to crossbeam-channel without any problems. However, the crate was released only yesterday, so right now I want as much real-world testing as possible so that we uncover and fix all potential bugs (if there are any).

stjepang commented Nov 27, 2017

I'll give it a try in my cmail and fst commands

Please do! If you have any feedback, let me know. :)

So far I've written a fairly extensive suite of unit tests and managed to switch Servo from mpsc to crossbeam-channel without any problems. However, the crate was released only yesterday, so right now I want as much real-world testing as possible so that we uncover and fix all potential bugs (if there are any).

@stjepang

This comment has been minimized.

Show comment
Hide comment
@stjepang

stjepang Jun 11, 2018

Just published version 0.2.0 of crossbeam-channel:
https://docs.rs/crossbeam-channel/0.2.0/crossbeam_channel/

The interface of these two crates is now almost identical.

stjepang commented Jun 11, 2018

Just published version 0.2.0 of crossbeam-channel:
https://docs.rs/crossbeam-channel/0.2.0/crossbeam_channel/

The interface of these two crates is now almost identical.

@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Jun 26, 2018

Owner

For anyone coming here: my intent is still to EOL chan and update the README, but I'm behind in variety of book-keeping work.

Owner

BurntSushi commented Jun 26, 2018

For anyone coming here: my intent is still to EOL chan and update the README, but I'm behind in variety of book-keeping work.

@heghe heghe referenced this issue Jul 18, 2018

Merged

Add key repetition #16

10 of 10 tasks complete
@BurntSushi

This comment has been minimized.

Show comment
Hide comment
@BurntSushi

BurntSushi Aug 1, 2018

Owner

This is done. I've spread the word that chan is dead! Long live crossbeam-channel!

Owner

BurntSushi commented Aug 1, 2018

This is done. I've spread the word that chan is dead! Long live crossbeam-channel!

@BurntSushi BurntSushi closed this Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment