From 4836ac3e28bcb6942470d3b20e643be42e372511 Mon Sep 17 00:00:00 2001 From: Andrew Gallant Date: Thu, 13 Jun 2024 19:17:51 -0400 Subject: [PATCH] ci: use cross when enabled Unbelievably, some of the steps in the main CI configuration were using the hard-coded `cargo` instead of `${{ env.CARGO }}`. The latter will interpolate to `cross` for targets requiring cross compilation. And since all big endian targets are only tested via cross compilation, our CI was not test big endian at all (beyond testing that compilation succeeded). This led to a [performance optimization] [breaking big endian] targets. [performance optimization]: https://github.com/BurntSushi/memchr/pull/151 [breaking big endian]: https://github.com/BurntSushi/memchr/issues/152 --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 290074f..8c1565b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -122,13 +122,13 @@ jobs: - name: Show byte order for debugging run: ${{ env.CARGO }} test --verbose $TARGET byte_order -- --nocapture - name: Run tests - run: cargo test --verbose + run: ${{ env.CARGO }} test --verbose - name: Run with only 'alloc' enabled - run: cargo test --verbose --no-default-features --features alloc + run: ${{ env.CARGO }} test --verbose --no-default-features --features alloc - name: Run tests without any features enabled (core-only) - run: cargo test --verbose --no-default-features + run: ${{ env.CARGO }} test --verbose --no-default-features - name: Run tests with miscellaneous features - run: cargo test --verbose --features logging + run: ${{ env.CARGO }} test --verbose --features logging # Setup and run tests on the wasm32-wasi target via wasmtime. wasm: