Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ripgrep man page differs from CPU #1441

Open
bmwiedemann opened this issue Dec 5, 2019 · 1 comment
Open

ripgrep man page differs from CPU #1441

bmwiedemann opened this issue Dec 5, 2019 · 1 comment
Labels
bug

Comments

@bmwiedemann
Copy link

@bmwiedemann bmwiedemann commented Dec 5, 2019

What version of ripgrep are you using?

11.0.2

What operating system are you using ripgrep on?

openSUSE Tumbleweed

Describe your question, feature request, or bug.

While working on reproducible builds for openSUSE, I found that
ripgrep man page content differs on different CPUs

--- /usr/share/man/man1/rg.1.gz
-11\&.0\&.2 \-SIMD \-AVX (compiled) +SIMD +AVX (runtime)
+11\&.0\&.2 \-SIMD \-AVX (compiled) \-SIMD \-AVX (runtime)

The strings come from ripgrep-11.0.2/src/app.rs fn runtime_cpu_features()

If this is a bug, what are the steps to reproduce the behavior?

use my "rbk" script from the reproducibleopensuse repo (needs some setup and an openSUSE account) or do a distribution/release build on different CPUs (e.g. I use kvm -cpu qemu64 and -cpu host )

If this is a bug, what is the actual behavior?

The man page differs depending on build machine CPU.

If this is a bug, what is the expected behavior?

The man page should be the same on every build (everytime, everywhere)

See https://reproducible-builds.org/ for why this matters.

@BurntSushi

This comment has been minimized.

Copy link
Owner

@BurntSushi BurntSushi commented Dec 5, 2019

It's likely that the SIMD and AVX designations should be removed entirely from the man page, as they don't really make sense there. They are there probably because they are derived from the same template that drives the output of rg --version (which should show the SIMD and AVX designations).

@BurntSushi BurntSushi added the bug label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.