Adjust default Colour Scheme to suit both black and white terminal backgrounds

[cetra3]

Not sure whether this can be counted as an actual issue, but it looks like the default colours are more geared towards having a black background in your terminal, which can incur some readability when using a different terminal background colour.

Compare the two outputs between ag and rg:

As you can see ag is a bit more readable here, especially on file names.

I'm not advocating to copy silver searcher's colour scheme exactly, but it would be nice if the defaults worked nicely with both.

[BurntSushi]

I actually very much dislike ag's color scheme (the background color on the match makes it very hard for me to read), and I use a terminal with a white background. The screenshot in the README is my environment:

I see that your green is very very bright. Is that the problem for you? If so, you might want to tweak your terminal so that your green isn't so... fluorescent.

[BurntSushi]

One thing I missed is that ag's green is actually darker for you. That's interesting. I wonder if it's because I'm using BRIGHT_GREEN, which I did because that makes it bold on Windows. It looks like I should probably use GREEN instead on Unix and only use the BRIGHT_* variants on Windows?

[cetra3]

Yeah, I am not exactly married to ag's colour scheme either.

The Bright Green I have is the OSX Default in the Terminal Menu (0, 255, 0). It does look a lot better in your screenshots though, so maybe I have some colour profile set somewhere else.

I've adjusted it in my fork to use the normal colours rather than bright (i.e, Green is (0, 166,0)) and it appears to look a bit nicer for my setup, but I am now questioning whether my setup is standard or not:

[BurntSushi]

@cetra3 Yup, we just discovered the same thing at the same time. :-) rg should switch to GREEN but keep BRIGHT_GREEN on Windows. I misdiagnosed: I think your setup is fine.

[cetra3]

At, It would be easy to add some #[cfg(windows)] where needed if you'd want a PR for this.

Otherwise I think maybe including it in as part of this issue more properly is the way to go

[BurntSushi]

I'd be fine with some judicious use of cfg directives if you don't want to wait.