Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure intended builds run #1372

Merged
merged 4 commits into from Sep 11, 2019
Merged

Ensure intended builds run #1372

merged 4 commits into from Sep 11, 2019

Conversation

@jclem
Copy link
Contributor

jclem commented Sep 11, 2019

Since this workflow specifies runs-on: ${{matrix.os}}, the os parameter needs to be defined for every build run.

Even though include is defined just for pinned-musl and stable, the other builds will still run—include is just saying "when these parameters match existing jobs, include some additional ones".

I've also added sudo to your apt-get command here—when running steps directly on the VM (as opposed to Docker), you're not running as root, and so password-less sudo can be used where needed.

jclem added 3 commits Sep 11, 2019
@BurntSushi

This comment has been minimized.

Copy link
Owner

BurntSushi commented Sep 11, 2019

Even though include is defined just for pinned-musl and stable, the other builds will still run—include is just saying "when these parameters match existing jobs, include some additional ones".

Ahhhh, I see now. I had commented out some of the builds in order to debug and build out the CI stuff incrementally. Thank you so much for the clarification and fix!

@jclem

This comment has been minimized.

Copy link
Contributor Author

jclem commented Sep 11, 2019

You're welcome! I'm working on trying to get a fully passing workflow here—I think I need to install zsh as well.

@BurntSushi

This comment has been minimized.

Copy link
Owner

BurntSushi commented Sep 11, 2019

@jclem Oh I wouldn't worry about a fully passing workflow too much. Just getting the CI running again is fantastic! There's quite a bit more work required to move ripgrep over to GA that I still have to do anyway. :-) Thank you though!

@jclem

This comment has been minimized.

Copy link
Contributor Author

jclem commented Sep 11, 2019

Okay, sounds good! Obviously, feel free to just yank my changes here if that's easier than merging a PR.

@BurntSushi BurntSushi merged commit 8cb7271 into BurntSushi:master Sep 11, 2019
0 of 4 checks passed
0 of 4 checks passed
test (pinned-musl)
Details
test (stable)
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.