Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure intended builds run #1372
Conversation
This comment has been minimized.
This comment has been minimized.
Ahhhh, I see now. I had commented out some of the builds in order to debug and build out the CI stuff incrementally. Thank you so much for the clarification and fix! |
This comment has been minimized.
This comment has been minimized.
|
You're welcome! I'm working on trying to get a fully passing workflow here—I think I need to install |
This comment has been minimized.
This comment has been minimized.
|
@jclem Oh I wouldn't worry about a fully passing workflow too much. Just getting the CI running again is fantastic! There's quite a bit more work required to move ripgrep over to GA that I still have to do anyway. :-) Thank you though! |
This comment has been minimized.
This comment has been minimized.
|
Okay, sounds good! Obviously, feel free to just yank my changes here if that's easier than merging a PR. |
jclem commentedSep 11, 2019
•
edited
Since this workflow specifies
runs-on: ${{matrix.os}}, theosparameter needs to be defined for every build run.Even though
includeis defined just forpinned-muslandstable, the otherbuilds will still run—includeis just saying "when these parameters match existing jobs, include some additional ones".I've also added
sudoto yourapt-getcommand here—when running steps directly on the VM (as opposed to Docker), you're not running as root, and so password-less sudo can be used where needed.