Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update globset and ignore's cargo manifest urls #1505

Merged
merged 2 commits into from Feb 29, 2020
Merged

update globset and ignore's cargo manifest urls #1505

merged 2 commits into from Feb 29, 2020

Conversation

chippers
Copy link
Contributor

The homepage and repo urls for ignore and globset manifest keys weren't updated when the project structure changed, leading links from https://docs.rs and https://crates.io to 404s.

Sorry about the PR on the new globset repo, I happened to find it first before this crates directory.

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! While you're here, would you might updating the links for the rest of the crates in the crates directory? I missed this when I did a re-org.

@chippers
Copy link
Contributor Author

These two were the only ones that were not pointing to ripgrep root, I'll update the other ones from the root to their directory

@BurntSushi
Copy link
Owner

Ah that would be great, thanks!

Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants