Allow specifying patterns with -f FILE and -f-
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emk This looks superb! I think this is good to go as is after a rebase (sorry about that, did some bug fixing last night). |
This is a somewhat basic implementation of `-f-` (BurntSushi#7), with unit tests. Changes include: 1. The internals of the `pattern` function have been refactored to avoid code duplication, but there's a lot more we could do. Right now we read the entire pattern list into a `Vec`. 2. There's now a `WorkDir::pipe` command that allows sending standard input to `rg` when testing. Not implemented: aho-corasick.
|
As requested, I've rebased this onto |
|
Thank you! |
|
Hey @BurntSushi, just a reminder that you may want to update your blog post, which says in part:
|
|
@ravron Thanks for the reminder! Updated. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat basic implementation of
-f-(#7), with unit tests, just to start a discussion. Your suggestions are very welcome, of course!Changes include:
patternfunction have been refactored to avoid code duplication, but there's a lot more we could do. Right now we read the entire pattern list into aVec.WorkDir::pipecommand that allows sending standard input torgwhen testing.Not yet implemented: aho-corasick, or any kind of sensible support for other extremely large inputs.
Thank you for helping me get this far, and for any further suggestions!