New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #236

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@SamWhited
Copy link

SamWhited commented Dec 17, 2018

Hello,

Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go (although the import path doesn't change with this library, so it doesn't matter much here).

Because this library has no external dependencies, is still below version 2, and is already tagging its releases using semver compatible tags, not much changes in the library itself except to declare the canonical import path and the language being used in a go.mod file.
I picked Go 1.9 as the language being used because running tests with 1.9 appeared to work, and that's the earliest version that has some basic support for modules backported into it. Since only things using modules will read this file (and everything else will work exactly as it always had), that seemed like a safe bet for maximum compatibility. If you only support some higher version of Go and want to use features or APIs in a higher version this can be changed easily, of course.

Thank you for your consideration.

EDIT: the test failures appear to be unrelated and occurring everywhere. Even if this library is now unsupported it would be nice if this could be merged (and then maybe the project could be marked as such so that others will know to fork it). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment