Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ? in docs instead of unwrapping #25

Closed
4 tasks
KodrAus opened this issue Jun 14, 2017 · 0 comments
Closed
4 tasks

Use ? in docs instead of unwrapping #25

KodrAus opened this issue Jun 14, 2017 · 0 comments

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Jun 14, 2017

Relevant API Guideline

Instead of calling unwrap in the doc examples, we should use the ? operator:

  • examples in crate root
  • examples on WalkDir type
  • examples on WalkDirIterator.skip_current_dir
  • examples on WalkDirIterator.filter_entry
@KodrAus KodrAus mentioned this issue Jun 14, 2017
Closed
22 tasks
msehnout pushed a commit to msehnout/walkdir that referenced this issue Jun 16, 2017
Use ? in docs instead of unwrapping
1d43a33 
Fixes: BurntSushi#25
@msehnout msehnout mentioned this issue Jun 16, 2017
Merged
msehnout pushed a commit to msehnout/walkdir that referenced this issue Jun 19, 2017
Use ? in docs instead of unwrapping
b984671 
Fixes: BurntSushi#25
msehnout pushed a commit to msehnout/walkdir that referenced this issue Jun 19, 2017
Use ? in docs instead of unwrapping
b2e3670 
Fixes: BurntSushi#25
msehnout pushed a commit to msehnout/walkdir that referenced this issue Jun 30, 2017
Use ? in docs instead of unwrapping
672499f 
Fixes: BurntSushi#25
BurntSushi pushed a commit that referenced this issue Jun 30, 2017
@BurntSushi
Use ? in docs instead of unwrapping
938b0fa 
Fixes: #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KodrAus