Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to other walkdir items in WalkDirIterator docs #30

Closed
4 tasks
KodrAus opened this issue Jun 14, 2017 · 3 comments · Fixed by #71
Closed
4 tasks

Add links to other walkdir items in WalkDirIterator docs #30

KodrAus opened this issue Jun 14, 2017 · 3 comments · Fixed by #71

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Jun 14, 2017

Relevant API Guideline

Add reference links in the WalkDirIterator docs prose when mentioning other walkdir items:

  • WalkDirIterator::filter_entry in WalkDirIterator::skip_current_dir
  • WalkDirIterator::skip_current_dir in WalkDirIterator::filter_entry
  • WalkDir::min_depth in WalkDirIterator::filter_entry
  • WalkDir::max_depth in WalkDirIterator::filter_entry
@KodrAus KodrAus mentioned this issue Jun 14, 2017
Closed
22 tasks
@expenses expenses mentioned this issue Jul 6, 2017
Merged
@meven
Copy link
Contributor

meven commented Jul 6, 2017

I have opened a pull request filling those gaps and a bit more.
#73

@meven meven mentioned this issue Jul 6, 2017
Merged
@meven
Copy link
Contributor

meven commented Jul 7, 2017 •
edited
Loading

#71 covers most of my Pull-request already and probably in a better way.

@KodrAus
Copy link
Contributor Author

KodrAus commented Jul 16, 2017

Closed by #73

@KodrAus KodrAus closed this as completed Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Link references in docs (#39)
2 participants
@meven @KodrAus