Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make skip_current_dir and filter_entry inherent methods #40

Closed
3 tasks
KodrAus opened this issue Jun 14, 2017 · 0 comments
Closed
3 tasks

Make skip_current_dir and filter_entry inherent methods #40

KodrAus opened this issue Jun 14, 2017 · 0 comments

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Jun 14, 2017

The WalkDirIterator trait isn't pulling its weight, so we should make them inherent methods and remove the trait. The plan is:

  • Make the skip_current_dir and filter_entry methods inherent methods on Iter and IterFilterEntry
  • Deprecate the WalkDirIterator trait for a non-breaking release
  • Remove the WalkDirIterator trait for the next breaking release
@KodrAus KodrAus mentioned this issue Jun 14, 2017
Closed
22 tasks
This was referenced Jun 24, 2017
Closed
Merged
BurntSushi pushed a commit that referenced this issue Jun 27, 2017
@nivkner @BurntSushi
Remove WalkDirIterator (#58)
fb40eaf 
remove WalkDirIterator

And make skip_current_dir and filter_entry inherent methods.

Fixes #40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KodrAus