Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove re-export of is_same_file #43

Closed
2 tasks
KodrAus opened this issue Jun 14, 2017 · 0 comments
Closed
2 tasks

Remove re-export of is_same_file #43

KodrAus opened this issue Jun 14, 2017 · 0 comments

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Jun 14, 2017

The is_same_file function doesn't need to be re-exported in walkdir anymore now that there's a dedicated same_file crate. The plan is:

  • Deprecate the is_same_file re-export for a non-breaking release
  • Remove the is_same_file re-export for the next breaking release
@KodrAus KodrAus mentioned this issue Jun 14, 2017
Closed
22 tasks
jeremielate added a commit to jeremielate/walkdir that referenced this issue Jun 22, 2017
@jeremielate
Remove re-export of is_same_file
17444a6 
Added a wrapper around this function that is deprecated.
Fixes BurntSushi#43.
@jeremielate jeremielate mentioned this issue Jun 22, 2017
Merged
BurntSushi pushed a commit that referenced this issue Jul 15, 2017
@jeremielate @BurntSushi
Remove re-export of is_same_file
f4de7b9 
Added a wrapper around this function that is deprecated.
Fixes #43.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KodrAus