Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded categories to Cargo.toml #49
Conversation
budziq
force-pushed the
budziq:fix_categories
branch
from
2709618
to
d70e775
Jun 14, 2017
budziq
force-pushed the
budziq:fix_categories
branch
from
d70e775
to
54ade17
Jun 14, 2017
This comment has been minimized.
This comment has been minimized.
|
Are we happy with just the filesystem category? I couldn't really see any others that looked applicable. |
This comment has been minimized.
This comment has been minimized.
|
I could not find any other sensible category as In rust cookbook we have also settled on categorizing walkdir examples under I'll gladly update if anyone has better idea. |
tmccombs
approved these changes
Jun 25, 2017
This comment has been minimized.
This comment has been minimized.
|
Seems fine to me! |
BurntSushi
merged commit 6a03164
into
BurntSushi:master
Jun 26, 2017
KodrAus
referenced this pull request
Jun 26, 2017
Closed
Tracking issue for libz blitz evaluation of walkdir #47
budziq
deleted the
budziq:fix_categories
branch
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
budziq commentedJun 14, 2017
fixes #36