Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added html_root_url attribute #51

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
4 participants
@budziq
Copy link
Contributor

budziq commented Jun 14, 2017

Typically the # remember to update html_root_url clause is added next to the version field in Cargo.toml as stated in C-HTML-ROOT

But I did not know if the #:version comment was relevant (possibly part of some uncommited script?)

I'll be glad to fix it.
fixes #33

@KodrAus

This comment has been minimized.

Copy link
Contributor

KodrAus commented Jun 15, 2017

Having a comment in the Cargo.toml as a reminder to update the attribute is a nice touch 👍

@BurntSushi BurntSushi merged commit 032f669 into BurntSushi:master Jun 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BurntSushi

This comment has been minimized.

Copy link
Owner

BurntSushi commented Jun 26, 2017

Indeed, the #:version comment is for one of my automated scripts that does releases. This looks fine! Thanks!

@KodrAus KodrAus referenced this pull request Jun 26, 2017

Closed

Tracking issue for libz blitz evaluation of walkdir #47

22 of 22 tasks complete

@budziq budziq deleted the budziq:fix_html_root_url branch Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.