Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove re-export of is_same_file #56
Conversation
KodrAus
reviewed
Jun 26, 2017
|
Thanks @jeremielate! I've just left a comment about deprecating the |
| @@ -101,7 +101,12 @@ use std::path::{Path, PathBuf}; | |||
| use std::result; | |||
| use std::vec; | |||
|
|
|||
| pub use same_file::is_same_file; | |||
This comment has been minimized.
This comment has been minimized.
KodrAus
Jun 26, 2017
Contributor
Should we be able to apply the deprecated attribute to this re-export? Is there a reason not to?
This was referenced Jun 26, 2017
This comment has been minimized.
This comment has been minimized.
|
Since we're releasing a |
This comment has been minimized.
This comment has been minimized.
brson
commented
Jul 6, 2017
|
sgtm @jeremielate can you update the pr to remove the deprecated function? |
KodrAus
approved these changes
Jul 6, 2017
This comment has been minimized.
This comment has been minimized.
brson
commented
Jul 15, 2017
|
This is ready for another look @BurntSushi |
This comment has been minimized.
This comment has been minimized.
|
Thanks @jeremielate! |
BurntSushi
merged commit 86238d6
into
BurntSushi:master
Jul 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jeremielate commentedJun 22, 2017
Added a wrapper around this function that is deprecated.
Fixes #43.