Derive Debug for public structs #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
reviewed
Jun 26, 2017
src/lib.rs
Outdated
| @@ -195,6 +196,20 @@ struct WalkDirOptions { | |||
| contents_first: bool, | |||
| } | |||
|
|
|||
| impl fmt::Debug for WalkDirOptions { | |||
| fn fmt(&self, f: &mut fmt::Formatter) -> ::std::result::Result<(), fmt::Error> { | |||
| write!(f, "WalkDirOptions {{ follow_links: {:?}, max_open: {:?}, \ | |||
There was a problem hiding this comment.
Do we need to manually implement Debug for the sort_by field?
There's a handy debug_struct method on Formatter that we could use here to simplify this implementation.
There was a problem hiding this comment.
Yes, this should definitely be using debug_struct.
|
Hmm, it looks like we might have to do some more |
|
Looks like we'll bump the minimum version to |
|
r? @BurntSushi |
|
Do you think this one is good to go now @BurntSushi? |
|
@KodrAus Ah yup, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34