Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDerive Debug for public structs #59
Conversation
KodrAus
reviewed
Jun 26, 2017
src/lib.rs
Outdated
| @@ -195,6 +196,20 @@ struct WalkDirOptions { | |||
| contents_first: bool, | |||
| } | |||
|
|
|||
| impl fmt::Debug for WalkDirOptions { | |||
| fn fmt(&self, f: &mut fmt::Formatter) -> ::std::result::Result<(), fmt::Error> { | |||
| write!(f, "WalkDirOptions {{ follow_links: {:?}, max_open: {:?}, \ | |||
This comment has been minimized.
This comment has been minimized.
KodrAus
Jun 26, 2017
Contributor
Do we need to manually implement Debug for the sort_by field?
There's a handy debug_struct method on Formatter that we could use here to simplify this implementation.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hmm, it looks like we might have to do some more |
This comment has been minimized.
This comment has been minimized.
|
Looks like we'll bump the minimum version to |
tmccombs
force-pushed the
tmccombs:derive-debug
branch
from
2b2bff2
to
1370694
Jun 28, 2017
tmccombs
force-pushed the
tmccombs:derive-debug
branch
from
1370694
to
f6ec352
Jul 3, 2017
This comment has been minimized.
This comment has been minimized.
brson
commented
Jul 6, 2017
|
r? @BurntSushi |
BurntSushi
added some commits
Jul 15, 2017
This comment has been minimized.
This comment has been minimized.
|
Do you think this one is good to go now @BurntSushi? |
BurntSushi
merged commit 079d145
into
BurntSushi:master
Jul 31, 2017
This comment has been minimized.
This comment has been minimized.
|
@KodrAus Ah yup, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tmccombs commentedJun 25, 2017
Fixes #34